Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions vcx_credential_get_attributes, vcx_disclosed_proof_get_proof_request_attachment #141

Merged
merged 12 commits into from
Oct 21, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 15, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

@mirgee mirgee requested a review from a team as a code owner October 15, 2020 18:55
@mirgee mirgee changed the title WIP: Expose get requested attributes for holder WIP: Expose get attributes for holder Oct 15, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee changed the title WIP: Expose get attributes for holder Expose get attributes for holder Oct 16, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #141 into master will decrease coverage by 0.05%.
The diff coverage is 43.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   50.76%   50.71%   -0.06%     
==========================================
  Files         151      151              
  Lines       22798    22916     +118     
  Branches     6028     6064      +36     
==========================================
+ Hits        11574    11621      +47     
- Misses       7654     7707      +53     
- Partials     3570     3588      +18     
Flag Coverage Δ
#unittests 50.71% <43.06%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/credential.rs 37.65% <0.00%> (-1.91%) ⬇️
libvcx/src/api/disclosed_proof.rs 42.37% <0.00%> (-1.92%) ⬇️
libvcx/src/aries/messages/issuance/credential.rs 67.34% <0.00%> (-15.16%) ⬇️
...cx/src/aries/messages/issuance/credential_offer.rs 77.14% <ø> (ø)
.../aries/handlers/issuance/holder/states/finished.rs 38.09% <50.00%> (+38.09%) ⬆️
.../handlers/issuance/holder/states/offer_received.rs 70.37% <63.63%> (+10.37%) ⬆️
libvcx/src/credential.rs 57.91% <64.70%> (+0.56%) ⬆️
...rc/aries/handlers/issuance/holder/state_machine.rs 66.94% <66.66%> (-0.01%) ⬇️
...aries/handlers/proof_presentation/prover/prover.rs 51.30% <66.66%> (+0.84%) ⬆️
libvcx/src/disclosed_proof.rs 66.80% <95.65%> (+0.68%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fd9aa...38986ee. Read the comment docs.

Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also extend Java and iOS wrapper? Probably any mobile app would want to use this.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename added function for proof to getProofRequestAttachment as we agreed

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas changed the title Expose get attributes for holder Add function vcx_credential_get_attributes, vcx_disclosed_proof_get_proof_request_attachment Oct 21, 2020
@Patrik-Stas Patrik-Stas changed the title Add function vcx_credential_get_attributes, vcx_disclosed_proof_get_proof_request_attachment Add functions vcx_credential_get_attributes, vcx_disclosed_proof_get_proof_request_attachment Oct 21, 2020
@Patrik-Stas Patrik-Stas merged commit afb0f34 into master Oct 21, 2020
@Patrik-Stas Patrik-Stas deleted the feature/get-attributes branch October 21, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants