Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust toolchain to 1.45.2 #154

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Update rust toolchain to 1.45.2 #154

merged 1 commit into from
Nov 2, 2020

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@Patrik-Stas Patrik-Stas requested a review from a team as a code owner October 18, 2020 20:37
@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #154 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   51.11%   51.08%   -0.03%     
==========================================
  Files         151      151              
  Lines       22923    22923              
  Branches     6053     6053              
==========================================
- Hits        11716    11711       -5     
- Misses       7600     7606       +6     
+ Partials     3607     3606       -1     
Flag Coverage Δ
unittests 51.08% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/lib.rs 33.39% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45d75e...701844b. Read the comment docs.

Copy link
Contributor

@mirgee mirgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update android.dockerfile for android build and build.sh for iOS.

@Patrik-Stas
Copy link
Contributor Author

@mirgee
iOS build fails with 1.47, perhaps we can downgrade rust for for iOS build and create issue for awareness?

@Patrik-Stas Patrik-Stas added the ci label Oct 30, 2020
@Patrik-Stas Patrik-Stas changed the title Update rust toolchain to 1.47.0 Update rust toolchain to 1.46.0 Nov 2, 2020
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Update rust toolchain to 1.46.0 Update rust toolchain to 1.45.2 Nov 2, 2020
@mirgee mirgee merged commit bca8470 into master Nov 2, 2020
@mirgee mirgee deleted the ci/update-rust branch November 2, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants