Split libvcx alpine image build in 2 phases #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
force-pushed
the
ci/optimize
branch
5 times, most recently
from
89f9119
to
f48f569
Compare
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 51.08% 51.10% +0.01%
==========================================
Files 151 151
Lines 22923 22923
Branches 6053 6053
==========================================
+ Hits 11711 11714 +3
+ Misses 7606 7603 -3
Partials 3606 3606
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Patrik-Stas
force-pushed
the
ci/optimize
branch
10 times, most recently
from
0c46d73
to
a5e52b7
Compare
mirgee
requested changes
Nov 2, 2020
Patrik-Stas
force-pushed
the
ci/optimize
branch
from
22fdf95
to
e5ff18c
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
ci/optimize
branch
from
e5ff18c
to
a81138d
Compare
mirgee
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everytime libvcx image (we have cache miss) we are currently rebuilding it from scratch. This includes building libindy and postgres plugin. This can takes more than 30 minutes and is blocking other jobs.
In this PR, we build separately alpine base image with libindy and posgres, which wouldn't change as often. Then on top of that, we'll build libvcx.
Signed-off-by: Patrik Stas patrik.stas@absa.africa