Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build for iOS wrapper #177

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Fix CI build for iOS wrapper #177

merged 1 commit into from
Oct 31, 2020

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Oct 30, 2020

Github Actions started by default using xcode 12 which causes us some issue when building for ios https://stackoverflow.com/questions/63607158/xcode-12-building-for-ios-simulator-but-linking-in-object-file-built-for-ios

Solved in this PR by switching back to xcode 11

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   51.11%   51.11%           
=======================================
  Files         151      151           
  Lines       22923    22923           
  Branches     6053     6053           
=======================================
  Hits        11716    11716           
  Misses       7600     7600           
  Partials     3607     3607           
Flag Coverage Δ
unittests 51.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45d75e...71e5172. Read the comment docs.

@Patrik-Stas Patrik-Stas added the ci label Oct 30, 2020
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Print xcode version in CI Fix CI build for iOS wrapper Oct 31, 2020
@Patrik-Stas Patrik-Stas merged commit 6222625 into master Oct 31, 2020
@Patrik-Stas Patrik-Stas deleted the ci/fix-ios-build branch October 31, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants