Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move agency_comm to separate crate #193

Merged
merged 27 commits into from
Nov 13, 2020
Merged

Move agency_comm to separate crate #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1189320
Reduce the dependency of agency_comm on vcx
mirgee Nov 6, 2020
5518989
Reduce deps further, successful build
mirgee Nov 10, 2020
c70e291
WIP: Move agency_comm into a crate
mirgee Nov 11, 2020
18e04c2
Move thread to messages
mirgee Nov 11, 2020
a0eb84b
Comment out test imports in agency_comm
mirgee Nov 11, 2020
d6f5a01
Use environment variable to signal test mode to agency_comm
mirgee Nov 11, 2020
de7232f
Fix failing unit tests
mirgee Nov 11, 2020
3bed7ba
Use 2018 edition in agency_comm
mirgee Nov 11, 2020
d3f26dc
Fix libvcx.dockerfile
mirgee Nov 11, 2020
59b4b1a
Fix codecov dockerfile
mirgee Nov 11, 2020
b50905e
Fix repo path in android.build.sh
mirgee Nov 11, 2020
404bf79
Fix wrapper tests
mirgee Nov 11, 2020
fb6a6b9
Fix codecov
mirgee Nov 11, 2020
7498dad
Fix ios build path
mirgee Nov 11, 2020
769e910
Fix anon/auth unpack
mirgee Nov 12, 2020
3d8889c
Merge branch 'master' into refactor/separate-agency-comm
mirgee Nov 12, 2020
5b711ee
Fix integration tests, run agency_comm unit tests
mirgee Nov 12, 2020
6165bf2
Cleanup dependencies
mirgee Nov 12, 2020
f43411d
Rename error to AgencyCommError
mirgee Nov 12, 2020
f2f0b53
Cleanup errors
mirgee Nov 12, 2020
55b6c42
Rename agency_comm to agency_client
mirgee Nov 12, 2020
63af688
Move integration test to ariesvcx
mirgee Nov 12, 2020
ec6cc7a
Move httpmocks, rename error to AgencyClientError
mirgee Nov 13, 2020
65b97bd
Avoid using envvar to setup mocks
mirgee Nov 13, 2020
809f9dc
Move private modules to utils
mirgee Nov 13, 2020
e5ad92f
Rename result type
mirgee Nov 13, 2020
7f2c53d
Remove unused agency_client imports
mirgee Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/codecov-integration-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ runs:
-e RUSTFLAGS='-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' \
-e RUSTDOCFLAGS='-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' \
${{ inputs.codecov-img-name }} \
bash -c '(cd $HOME/libvcx && \
bash -c '(cd $HOME/aries-vcx/libvcx && \
cargo test --features "pool_tests agency_v2" && \
grcov ./target/debug/ -s . -t lcov --llvm --branch --ignore-not-existing -o ./target/debug/coverage.lcov)'
grcov ../target/debug/ -s . -t lcov --llvm --branch --ignore-not-existing -o ../target/debug/coverage.lcov)'
docker_id=$(docker ps -a | grep libvcx-codecov-integration | grep Exited | tail -n 1 | cut -d ' ' -f 1)
docker_image_id=$(docker images | grep codecov | perl -pe 's/\s+/ /g' | cut -d ' ' -f 3)
docker cp ${docker_id}:/home/indy/libvcx/target/debug/coverage.lcov ${{ inputs.cov-file-path }}
docker cp ${docker_id}:/home/indy/aries-vcx/target/debug/coverage.lcov ${{ inputs.cov-file-path }}
docker rm ${docker_id} > /dev/null
docker rmi ${docker_image_id} > /dev/null
shell: bash
6 changes: 3 additions & 3 deletions .github/actions/codecov-unit-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ runs:
-e RUSTFLAGS='-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' \
-e RUSTDOCFLAGS='-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' \
${{ inputs.docker-img-name }} \
bash -c '(cd $HOME/libvcx && \
bash -c '(cd $HOME/aries-vcx/libvcx && \
cargo test --features "general_test aries" && \
grcov ./target/debug/ -s . -t lcov --llvm --branch --ignore-not-existing -o ./target/debug/coverage.lcov)'
grcov ../target/debug/ -s . -t lcov --llvm --branch --ignore-not-existing -o ../target/debug/coverage.lcov)'
docker_id=$(docker ps -a | grep libvcx-codecov-unit | grep Exited | tail -n 1 | cut -d ' ' -f 1)
docker_image_id=$(docker images | grep codecov | perl -pe 's/\s+/ /g' | cut -d ' ' -f 3)
docker cp ${docker_id}:/home/indy/libvcx/target/debug/coverage.lcov ${{ inputs.cov-file-path }}
docker cp ${docker_id}:/home/indy/aries-vcx/target/debug/coverage.lcov ${{ inputs.cov-file-path }}
docker rm ${docker_id} > /dev/null
docker rmi ${docker_image_id} > /dev/null
shell: bash
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,9 @@ jobs:
set -x
docker run --rm -i --name libvcx --network host $DOCKER_IMG_NAME_LIBVCX \
bash -c '(cd $HOME/libvcx && \
RUST_TEST_THREADS=1 cargo test --release --features "general_test aries")'
RUST_TEST_THREADS=1 cargo test --release --features "general_test aries" && \
cd $HOME/agency_client && \
RUST_TEST_THREADS=1 cargo test --release --features "general_test")'

test-libvcx-image-pool_tests:
runs-on: ubuntu-latest
Expand Down
Loading