Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated init functions, migrate tests #199

Merged
merged 9 commits into from
Nov 12, 2020

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Nov 9, 2020

  • Delete vcx_init_with_config, vcx_init, vcx_init_minimal.
  • As substitution, you can use functions vcx_init_core, vcx_open_pool, vcx_open_wallet
  • Migrated tests associated with the deprecated function to use the substitute functions

Signed-off-by: Patrik Stas patrik.stas@absa.africa

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2020

This pull request introduces 2 alerts when merging 4ea6681 into 73c3dfe - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #199 (5545b11) into master (7926015) will decrease coverage by 0.13%.
The diff coverage is 74.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   57.61%   57.47%   -0.14%     
==========================================
  Files         156      156              
  Lines       24070    23907     -163     
  Branches     6271     6217      -54     
==========================================
- Hits        13867    13740     -127     
- Misses       6207     6219      +12     
+ Partials     3996     3948      -48     
Flag Coverage Δ
integration 35.17% <63.85%> (-0.40%) ⬇️
unittests 50.69% <37.31%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/utils/devsetup.rs 47.82% <64.70%> (-0.68%) ⬇️
libvcx/src/api/vcx.rs 71.05% <76.25%> (+1.22%) ⬆️
libvcx/src/settings.rs 63.57% <0.00%> (-2.41%) ⬇️
libvcx/src/agency_comm/mocking.rs 62.26% <0.00%> (-1.89%) ⬇️
libvcx/src/agency_comm/utils/agent_utils.rs 53.11% <0.00%> (-1.47%) ⬇️
libvcx/src/error/mod.rs 45.51% <0.00%> (-0.72%) ⬇️
libvcx/src/api/utils.rs 32.95% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7926015...5545b11. Read the comment docs.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2020

This pull request introduces 2 alerts when merging 5545b11 into 73c3dfe - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2020

This pull request introduces 2 alerts when merging cfa33f1 into 84a722b - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@mirgee mirgee merged commit 1971000 into master Nov 12, 2020
@mirgee mirgee deleted the cleanup/delete-depreacted-api branch November 12, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants