Remove agency settings

[mirgee]

Removes the dependecy of aries-vcx on agency_client's agency_settings and creates an AgencyClient struct as a stepping stone toward multitenancy support.

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

[Patrik-Stas]

Let's hold off from extending API just yet. Let's keep this PR internal changes and refactoring only, then create issue with new API proposal (onboarding new agent, initializing existing agent, creating wallet, opening wallet, etc. ) - then implement those APIs in separate PR.

[Patrik-Stas]

Or maybe before thinking about aries-vcx apis, we can first define agency_client APIs for creation and initialization:

• create new client (create it in agency)
• create client instance (create client/initialize create which can be used to talk to agency)

Create new client

I think all we need to create new client is: agency_url, agency_did, agency_verkey and a wallet handle.
The output of this operation should be whatever is need to create client instance. I'd suggest to output to be JSON config, just as it is currently on vcx_provision_agent

Create client instance / initialization

The required information here should be

• agency_url
• agency_did
• agency_verkey
• remote_to_sdk_did
• remote_to_sdk_verkey
• sdk_to_remote_did
• sdk_to_remote_verkey
  and wallet handle, whereas it's up to agency_client consumer responsibility to pass in the correct wallet handle.

[Patrik-Stas]

However this should not yet impact aries-vcx. Let's first design good api for the agency_client, then we can enhance API for aries-vcx

[codecov-io]

Codecov Report

Merging #208 (cefac4a) into master (b4731de) will decrease coverage by 1.14%.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   58.84%   57.69%   -1.15%     
==========================================
  Files         148      149       +1     
  Lines       19408    19902     +494     
  Branches     4307     4464     +157     
==========================================
+ Hits        11420    11482      +62     
- Misses       4616     5071     +455     
+ Partials     3372     3349      -23     

Flag	Coverage Δ
integration	26.14% <28.39%> (-0.56%)	⬇️
unittests	51.95% <36.78%> (-0.97%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
agency_client/src/agency_client.rs	0.00% <0.00%> (ø)
agency_client/src/get_message.rs	85.71% <ø> (ø)
agency_client/src/lib.rs	57.14% <ø> (ø)
...aries/handlers/connection/invitee/state_machine.rs	71.58% <0.00%> (-0.20%)	⬇️
libvcx/src/connection.rs	61.81% <0.00%> (-0.15%)	⬇️
libvcx/src/init.rs	52.38% <0.00%> (-7.08%)	⬇️
libvcx/src/utils/error.rs	63.28% <ø> (ø)
libvcx/src/api/vcx.rs	69.34% <16.66%> (-3.14%)	⬇️
libvcx/src/error/mod.rs	34.56% <16.66%> (-1.12%)	⬇️
agency_client/src/error.rs	18.18% <20.00%> (ø)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4731de...cefac4a. Read the comment docs.