Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rev reg value caching in build rev states #213

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Nov 26, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #213 (4d6047c) into master (fd69db0) will decrease coverage by 0.23%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   60.94%   60.70%   -0.24%     
==========================================
  Files         147      147              
  Lines       19583    19310     -273     
  Branches     4316     4265      -51     
==========================================
- Hits        11934    11722     -212     
+ Misses       4200     4185      -15     
+ Partials     3449     3403      -46     
Flag Coverage Δ
integration 34.89% <70.00%> (-0.69%) ⬇️
unittests 53.46% <70.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/libindy/utils/cache.rs 0.00% <ø> (-33.71%) ⬇️
...ibvcx/src/libindy/proofs/prover/prover_internal.rs 81.89% <70.00%> (+0.80%) ⬆️
libvcx/src/libindy/utils/wallet.rs 71.11% <0.00%> (-1.12%) ⬇️
libvcx/src/libindy/utils/anoncreds.rs 80.80% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd69db0...4d6047c. Read the comment docs.

@mirgee mirgee added the bug Something isn't working label Nov 27, 2020
@Patrik-Stas Patrik-Stas merged commit a705b70 into master Nov 30, 2020
@Patrik-Stas Patrik-Stas deleted the hotfix/remove-cache branch November 30, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants