Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch pool image from GitHub Container Registry #217

Merged
merged 2 commits into from
Nov 28, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Nov 27, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee added hotfix High priority fixes of unexpected issues ci labels Nov 27, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee mentioned this pull request Nov 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #217 (2366fbf) into master (a2e491f) will increase coverage by 7.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   53.50%   60.94%   +7.43%     
==========================================
  Files         146      147       +1     
  Lines       18396    19583    +1187     
  Branches     4149     4316     +167     
==========================================
+ Hits         9842    11934    +2092     
+ Misses       5464     4200    -1264     
- Partials     3090     3449     +359     
Flag Coverage Δ
integration 35.58% <ø> (?)
unittests 53.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/lib.rs 57.14% <0.00%> (-4.40%) ⬇️
agency_client/src/payload.rs 0.00% <0.00%> (ø)
libvcx/src/utils/object_cache/mod.rs 66.31% <0.00%> (ø)
libvcx/src/aries/messages/discovery/query.rs 88.88% <0.00%> (ø)
libvcx/src/aries/messages/trust_ping/ping.rs 74.28% <0.00%> (ø)
libvcx/src/aries/messages/discovery/disclose.rs 82.05% <0.00%> (ø)
libvcx/src/aries/messages/basic_message/message.rs 67.74% <0.00%> (ø)
agency_client/src/get_message.rs 85.71% <0.00%> (ø)
...aries/handlers/connection/invitee/state_machine.rs 71.78% <0.00%> (+0.27%) ⬆️
libvcx/src/aries/handlers/connection/mod.rs 68.00% <0.00%> (+0.35%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e491f...2366fbf. Read the comment docs.

@Patrik-Stas Patrik-Stas merged commit 6b64d97 into master Nov 28, 2020
@Patrik-Stas Patrik-Stas deleted the ci/prebuilt-pool-img branch November 28, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants