Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split provision into API-exposed stages #219

Merged
merged 6 commits into from
Dec 4, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Nov 30, 2020

Adds new methods

  • vcx_create_wallet
  • vcx_configure_issuer_wallet
  • vcx_provision_new_agent
  • vcx_open_wallet_directly
  • vcx_close_wallet_directly

as per issue #209 in preparation for #210.

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #219 (1ac0f5d) into master (a705b70) will decrease coverage by 7.74%.
The diff coverage is 6.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   60.70%   52.95%   -7.75%     
==========================================
  Files         147      147              
  Lines       19310    18472     -838     
  Branches     4265     4167      -98     
==========================================
- Hits        11722     9782    -1940     
- Misses       4185     5605    +1420     
+ Partials     3403     3085     -318     
Flag Coverage Δ
integration ?
unittests 52.95% <6.86%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/utils.rs 31.01% <0.00%> (-2.42%) ⬇️
libvcx/src/api/wallet.rs 44.84% <0.00%> (-7.75%) ⬇️
libvcx/src/aries/mod.rs 1.06% <0.00%> (-83.26%) ⬇️
libvcx/src/libindy/utils/ledger.rs 11.78% <0.00%> (-39.01%) ⬇️
libvcx/src/libindy/utils/wallet.rs 63.02% <0.00%> (-8.09%) ⬇️
libvcx/src/settings.rs 60.48% <ø> (-3.10%) ⬇️
libvcx/src/utils/devsetup.rs 26.84% <0.00%> (-21.28%) ⬇️
libvcx/src/utils/mod.rs 100.00% <ø> (ø)
libvcx/src/utils/provision.rs 47.79% <0.00%> (-9.95%) ⬇️
libvcx/src/libindy/utils/anoncreds.rs 21.49% <5.26%> (-59.32%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a705b70...1ac0f5d. Read the comment docs.

libvcx/src/api/utils.rs Outdated Show resolved Hide resolved
libvcx/src/api/wallet.rs Outdated Show resolved Hide resolved
libvcx/src/api/wallet.rs Outdated Show resolved Hide resolved
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #219 (38add11) into master (3b7550a) will decrease coverage by 7.78%.
The diff coverage is 6.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   60.70%   52.91%   -7.79%     
==========================================
  Files         147      147              
  Lines       19310    18479     -831     
  Branches     4265     4170      -95     
==========================================
- Hits        11722     9779    -1943     
- Misses       4185     5613    +1428     
+ Partials     3403     3087     -316     
Flag Coverage Δ
integration ?
unittests 52.91% <6.69%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/utils.rs 31.18% <0.00%> (-2.25%) ⬇️
libvcx/src/api/wallet.rs 44.90% <0.00%> (-7.68%) ⬇️
libvcx/src/aries/mod.rs 1.04% <0.00%> (-83.27%) ⬇️
libvcx/src/libindy/utils/ledger.rs 11.74% <0.00%> (-39.06%) ⬇️
libvcx/src/libindy/utils/signus.rs 85.71% <0.00%> (-14.29%) ⬇️
libvcx/src/libindy/utils/wallet.rs 63.34% <0.00%> (-7.77%) ⬇️
libvcx/src/settings.rs 60.48% <ø> (-3.10%) ⬇️
libvcx/src/utils/author_agreement.rs 72.22% <0.00%> (-1.37%) ⬇️
libvcx/src/utils/devsetup.rs 26.70% <0.00%> (-21.43%) ⬇️
libvcx/src/utils/mod.rs 100.00% <ø> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7550a...ee6a555. Read the comment docs.

@mirgee mirgee force-pushed the refactor/split-provision branch 3 times, most recently from bff5f73 to 485a203 Compare December 2, 2020 16:27
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee added refactoring enhancement New feature or request labels Dec 2, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
libvcx/src/api/wallet.rs Show resolved Hide resolved
libvcx/src/api/wallet.rs Outdated Show resolved Hide resolved
libvcx/src/api/utils.rs Outdated Show resolved Hide resolved
libvcx/src/utils/devsetup.rs Outdated Show resolved Hide resolved
libvcx/src/libindy/utils/wallet.rs Outdated Show resolved Hide resolved
libvcx/src/libindy/utils/wallet.rs Outdated Show resolved Hide resolved
libvcx/src/libindy/utils/wallet.rs Outdated Show resolved Hide resolved
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Patrik-Stas Patrik-Stas merged commit b4731de into master Dec 4, 2020
@Patrik-Stas Patrik-Stas deleted the refactor/split-provision branch December 4, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants