Add new initialization methods #223

mirgee · 2020-12-03T15:55:04Z

Added methods:

vcx_init_threadpool - Initializes tokio threadpool
vcx_create_wallet - creates a new wallet and master secret using provided config (wallet name, key, key der. meth.), but keeps wallet closed
vcx_create_agency_client_for_main_wallet - creates a new agency client from config (agency and agent did, verkey, url, etc.)
vcx_open_main_pool - opens the pool
vcx_open_main_wallet - opens the created wallet
vcx_close_main_wallet - closes the created wallet
vcx_configure_issuer_wallet - creates and stores did and keypair for credential issuance
vcx_init_issuer_config - stores provided config used by issuer in the memory (inst. did, name and verkey)

Implements #210 .

Deprecated methods:

vcx_open_pool
vcx_agent_update_info
vcx_init_core
vcx_open_wallet

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> # Conflicts: # libvcx/src/api/vcx.rs # libvcx/src/aries/handlers/connection/agent_info.rs # libvcx/src/libindy/utils/wallet.rs # libvcx/src/settings.rs # libvcx/src/utils/devsetup.rs

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

codecov-io · 2020-12-03T16:58:53Z

Codecov Report

Merging #223 (07b7dca) into master (c872f0e) will increase coverage by 0.26%.
The diff coverage is 12.59%.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   57.38%   57.65%   +0.26%     
==========================================
  Files         149      149              
  Lines       19995    19800     -195     
  Branches     4497     4451      -46     
==========================================
- Hits        11474    11415      -59     
+ Misses       5174     5053     -121     
+ Partials     3347     3332      -15

Flag	Coverage Δ
integration	`26.42% <12.59%> (+0.45%)`	⬆️
unittests	`51.88% <12.59%> (+0.22%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libvcx/src/api/utils.rs	`31.18% <ø> (ø)`
libvcx/src/api/vcx.rs	`61.98% <0.00%> (-7.37%)`	⬇️
libvcx/src/api/wallet.rs	`47.44% <0.00%> (ø)`
libvcx/src/libindy/utils/wallet.rs	`70.20% <ø> (+1.04%)`	⬆️
libvcx/src/settings.rs	`66.42% <ø> (+2.81%)`	⬆️
libvcx/src/init.rs	`30.48% <4.65%> (-21.90%)`	⬇️
libvcx/src/utils/threadpool.rs	`74.19% <66.66%> (-4.07%)`	⬇️
libvcx/src/utils/devsetup.rs	`48.22% <100.00%> (ø)`
libvcx/src/aries/messages/connection/service.rs	`70.27% <0.00%> (-8.11%)`	⬇️
...essages/proof_presentation/presentation_request.rs	`75.00% <0.00%> (-4.17%)`	⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c872f0e...07b7dca. Read the comment docs.

Patrik-Stas

Could you also add this to NodeJS wrapper and write a test using new APIs for initialization? Perhaps migrate alice/faber demo?

libvcx/src/api/vcx.rs

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> # Conflicts: # agency_client/src/agent_utils.rs # agency_client/src/error.rs # agency_client/src/httpclient.rs # agency_client/src/utils/error_utils.rs # libvcx/src/api/vcx.rs # libvcx/src/init.rs # libvcx/src/libindy/utils/wallet.rs # libvcx/src/settings.rs # libvcx/src/utils/devsetup.rs # libvcx/src/utils/provision.rs

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

agents/node/vcxagent-core/src/agent.js

agents/node/vcxagent-core/src/utils/vcx-workflows.js

libvcx/src/api/vcx.rs

Patrik-Stas · 2020-12-08T20:32:16Z

Please list also deprecated functions in PR description

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> # Conflicts: # wrappers/node/src/api/utils.ts # wrappers/node/src/rustlib.ts

lgtm-com · 2021-01-04T15:34:53Z

This pull request introduces 1 alert when merging 7f75a34 into c872f0e - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

libvcx/src/api/vcx.rs

agents/node/vcxagent-core/src/agent.js

Patrik-Stas · 2021-01-04T16:28:09Z

wrappers/node/src/rustlib.ts

+  vcx_open_main_pool: (commandId: number, config: string, cb: any) => number,
+
+  vcx_create_agency_client_for_main_wallet: (commandId: number, config: string, cb: any) => number,
+  vcx_provision_cloud_agent: (commandId: number, config: string, cb: any) => number,


Seems like there no C function like this defined in rust?

It is, see libvcx/src/api/utils.rs:139

Patrik-Stas

I left few comments and updated list of added functions in PR description. Could you please also add there short 1-liner description for each new function

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

lgtm-com · 2021-01-05T09:31:36Z

This pull request introduces 1 alert when merging a92ccea into c872f0e - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

lgtm-com · 2021-01-05T10:02:54Z

This pull request introduces 2 alerts when merging e9cfeac into c872f0e - view on LGTM.com

new alerts:

1 for Superfluous trailing arguments
1 for Unused variable, import, function or class

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

* Add to java wrapper Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> Add to iOS wrapper Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Add to iOS wrapper Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee added 12 commits November 18, 2020 16:04

WIP: Replace agency settings

63f05df

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Move remove init client api

523d90b

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Do not use utils externally

a504eb5

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Fix failing unit test

be1ecb0

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Merge branch 'master' into refactor/replace-agency-settings

1580a40

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Fix wrapper tests

2756485

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Make aries-demo agency_pool_test

31f4487

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Fix failing pool test

fdfed56

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Rebuild libvcx image

8bba114

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Merge branch 'master' into refactor/replace-agency-settings

bd798a6

Add new initialization methods

ecec4f7

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee added the enhancement New feature or request label Dec 4, 2020

Patrik-Stas requested changes Dec 4, 2020

View reviewed changes

libvcx/src/api/vcx.rs Outdated Show resolved Hide resolved

libvcx/src/api/vcx.rs Outdated Show resolved Hide resolved

libvcx/src/api/vcx.rs Outdated Show resolved Hide resolved

libvcx/src/api/vcx.rs Show resolved Hide resolved

libvcx/src/api/vcx.rs Show resolved Hide resolved

Base automatically changed from refactor/replace-agency-settings to master December 4, 2020 11:57

Address some comments

b9fab21

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee force-pushed the feature/new-init-api branch from 1de2257 to b9fab21 Compare December 4, 2020 12:25

mirgee force-pushed the feature/new-init-api branch from 57e4c99 to 0d2631d Compare December 4, 2020 12:44

mirgee added 4 commits December 4, 2020 14:19

Add threadpool size param

444bad6

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Add new methods to wrapper

ae3b756

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Add remaining init methods

a89c873

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Transition demo to split provision

0e9b444

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee requested a review from Patrik-Stas December 4, 2020 16:27

Use new init in demo

dc254f2

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee force-pushed the feature/new-init-api branch from b1b84c9 to dc254f2 Compare December 4, 2020 16:31

hyperledger deleted a comment from lgtm-com bot Dec 4, 2020

Merge branch 'master' into feature/new-init-api

5d60c6c

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Add docstring to init_threadpool

a971a86

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee force-pushed the feature/new-init-api branch from b2fb691 to a971a86 Compare December 4, 2020 16:39

Patrik-Stas reviewed Dec 8, 2020

View reviewed changes

agents/node/vcxagent-core/src/agent.js Show resolved Hide resolved

Patrik-Stas reviewed Dec 8, 2020

View reviewed changes

agents/node/vcxagent-core/src/utils/vcx-workflows.js Outdated Show resolved Hide resolved

Patrik-Stas reviewed Dec 8, 2020

View reviewed changes

agents/node/vcxagent-core/src/utils/vcx-workflows.js Outdated Show resolved Hide resolved

Patrik-Stas reviewed Dec 8, 2020

View reviewed changes

libvcx/src/api/vcx.rs Outdated Show resolved Hide resolved

mirgee requested a review from a team as a code owner January 4, 2021 13:56

mirgee requested a review from Patrik-Stas January 4, 2021 13:56

Address code review comments

0714082

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee force-pushed the feature/new-init-api branch from 2138c0a to 0714082 Compare January 4, 2021 14:40

Merge branch 'master' into feature/new-init-api

7f75a34

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> # Conflicts: # wrappers/node/src/api/utils.ts # wrappers/node/src/rustlib.ts

Patrik-Stas reviewed Jan 4, 2021

View reviewed changes

libvcx/src/api/vcx.rs Outdated Show resolved Hide resolved

Patrik-Stas reviewed Jan 4, 2021

View reviewed changes

agents/node/vcxagent-core/src/agent.js Show resolved Hide resolved

Patrik-Stas reviewed Jan 4, 2021

View reviewed changes

Patrik-Stas requested changes Jan 4, 2021

View reviewed changes

Do return wh on opening due to tests

a92ccea

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Add legacy initialization test

e9cfeac

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee force-pushed the feature/new-init-api branch from da76151 to 51857a6 Compare January 5, 2021 12:45

Fix LGTM alerts

9080769

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

mirgee force-pushed the feature/new-init-api branch from 51857a6 to 9080769 Compare January 5, 2021 13:14

Patrik-Stas previously approved these changes Jan 5, 2021

View reviewed changes

Add new init methods to wrappers (#252)

07b7dca

* Add to java wrapper Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> Add to iOS wrapper Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> * Add to iOS wrapper Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Patrik-Stas dismissed their stale review via 07b7dca January 15, 2021 09:28

Patrik-Stas approved these changes Jan 15, 2021

View reviewed changes

Patrik-Stas merged commit c36c0f7 into master Jan 15, 2021

Patrik-Stas deleted the feature/new-init-api branch January 15, 2021 11:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new initialization methods #223

Add new initialization methods #223

mirgee commented Dec 3, 2020 •

edited

Loading

codecov-io commented Dec 3, 2020 •

edited

Loading

Patrik-Stas left a comment

Patrik-Stas commented Dec 8, 2020

lgtm-com bot commented Jan 4, 2021

Patrik-Stas Jan 4, 2021

mirgee Jan 5, 2021 •

edited

Loading

Patrik-Stas left a comment

lgtm-com bot commented Jan 5, 2021

lgtm-com bot commented Jan 5, 2021

Add new initialization methods #223

Add new initialization methods #223

Conversation

mirgee commented Dec 3, 2020 • edited Loading

codecov-io commented Dec 3, 2020 • edited Loading

Codecov Report

Patrik-Stas left a comment

Choose a reason for hiding this comment

Patrik-Stas commented Dec 8, 2020

lgtm-com bot commented Jan 4, 2021

Patrik-Stas Jan 4, 2021

Choose a reason for hiding this comment

mirgee Jan 5, 2021 • edited Loading

Choose a reason for hiding this comment

Patrik-Stas left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Jan 5, 2021

lgtm-com bot commented Jan 5, 2021

mirgee commented Dec 3, 2020 •

edited

Loading

codecov-io commented Dec 3, 2020 •

edited

Loading

mirgee Jan 5, 2021 •

edited

Loading