Init rust api once #228
Merged
Init rust api once #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 57.69% 57.69%
=======================================
Files 149 149
Lines 19902 19902
Branches 4464 4464
=======================================
Hits 11482 11482
Misses 5071 5071
Partials 3349 3349
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Patrik-Stas
requested changes
Dec 8, 2020
added 6 commits
December 9, 2020 18:15
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
OoDeLally
force-pushed
the
init-rust-api-once
branch
from
e0f6d65
to
3f3eb2f
Compare
Patrik-Stas
previously approved these changes
Dec 10, 2020
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
OoDeLally
force-pushed
the
init-rust-api-once
branch
from
0d36584
to
ba556df
Compare
Patrik-Stas
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents to call
initRustAPI()several time and needlessly load the Rust library several times.User functions are no longer responsible for loading it. Instead the top caller should load it once for everyone.