Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use available OpenSSL library #236

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

OoDeLally
Copy link
Contributor

Signed-off-by: Pascal Heitz pascal.heitz@absa.africa

@OoDeLally OoDeLally requested a review from a team as a code owner December 14, 2020 11:12
@OoDeLally OoDeLally marked this pull request as draft December 14, 2020 11:12
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #236 (3b79849) into master (82f5210) will decrease coverage by 5.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   57.69%   51.95%   -5.74%     
==========================================
  Files         149      148       -1     
  Lines       19902    18973     -929     
  Branches     4464     4327     -137     
==========================================
- Hits        11482     9858    -1624     
- Misses       5071     6051     +980     
+ Partials     3349     3064     -285     
Flag Coverage Δ
integration ?
unittests 51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/libindy/utils/anoncreds.rs 21.49% <0.00%> (-59.16%) ⬇️
libvcx/src/libindy/utils/pool.rs 17.39% <0.00%> (-58.66%) ⬇️
libvcx/src/utils/plugins.rs 0.00% <0.00%> (-42.86%) ⬇️
libvcx/src/libindy/utils/ledger.rs 11.74% <0.00%> (-39.24%) ⬇️
libvcx/src/aries/mod.rs 1.04% <0.00%> (-30.77%) ⬇️
libvcx/src/utils/random.rs 75.00% <0.00%> (-25.00%) ⬇️
libvcx/src/utils/devsetup.rs 26.70% <0.00%> (-21.53%) ⬇️
libvcx/src/libindy/utils/payments.rs 42.98% <0.00%> (-21.15%) ⬇️
libvcx/src/libindy/proofs/verifier/verifier.rs 70.37% <0.00%> (-18.06%) ⬇️
...aries/handlers/proof_presentation/prover/prover.rs 57.79% <0.00%> (-17.32%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f5210...3b79849. Read the comment docs.

Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
@OoDeLally OoDeLally changed the title log ls cellar Use available OpenSSL library Dec 18, 2020
@OoDeLally OoDeLally marked this pull request as ready for review December 18, 2020 13:37
@Patrik-Stas Patrik-Stas merged commit 5e3948d into master Dec 18, 2020
@Patrik-Stas Patrik-Stas deleted the fix-publish-ios-wrapper branch December 18, 2020 13:47
@Patrik-Stas Patrik-Stas added the ci label Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants