Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate update functions API and add their alternatives #240

Merged
merged 3 commits into from
Dec 20, 2020

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner December 19, 2020 20:06
@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #240 (3b41b05) into master (82f5210) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   57.69%   57.38%   -0.31%     
==========================================
  Files         149      149              
  Lines       19902    20009     +107     
  Branches     4464     4502      +38     
==========================================
  Hits        11482    11482              
- Misses       5071     5178     +107     
  Partials     3349     3349              
Flag Coverage Δ
integration 25.95% <0.00%> (-0.19%) ⬇️
unittests 51.66% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/credential.rs 31.79% <0.00%> (-1.77%) ⬇️
libvcx/src/api/disclosed_proof.rs 39.15% <0.00%> (-1.89%) ⬇️
libvcx/src/api/issuer_credential.rs 35.08% <0.00%> (-1.80%) ⬇️
libvcx/src/api/proof.rs 49.36% <0.00%> (-3.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f5210...3b41b05. Read the comment docs.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Deprecate update functions API not enforcing passing connection handle Deprecate update functions API and add their alternatives Dec 20, 2020
@Patrik-Stas Patrik-Stas merged commit 71237f3 into master Dec 20, 2020
@Patrik-Stas Patrik-Stas deleted the deprecate/not-enforcing-connection branch December 20, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants