Remove deprecated cred update functions, refactor cred FSM

[Patrik-Stas]

1. Remove support for

• vcx_credential_update_state, vcx_credential_update_state_with_message,
• vcx_issuer_credential_update_state , vcx_issuer_credential_update_state,
• vcx_disclosed_proof_update_state, vcx_disclosed_proof_update_state_with_message,
• vcx_proof_update_state, vcx_proof_update_state_with_message,
  Instead you should use vcx_v2_* versions of these functions which require connection handle as parameter

2. Refactor aries state machines such that it doesn't store connection handle, but rather getting handle passed down via funcion args.

Signed-off-by: Patrik Stas patrik.stas@absa.africa

[Patrik-Stas]

Hey @mirgee, enjoy your holidays, but just in case you want to take a look at this, I've set you as reviewer.

[codecov-io]

Codecov Report

Merging #243 (6cae662) into master (c872f0e) will increase coverage by 0.53%.
The diff coverage is 75.08%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   57.38%   57.91%   +0.53%     
==========================================
  Files         149      149              
  Lines       19995    19766     -229     
  Branches     4497     4435      -62     
==========================================
- Hits        11474    11448      -26     
+ Misses       5174     4973     -201     
+ Partials     3347     3345       -2     

Flag	Coverage Δ
integration	26.44% <2.08%> (+0.46%)	⬆️
unittests	52.15% <75.08%> (+0.49%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libvcx/src/api/disclosed_proof.rs	42.17% <0.00%> (+3.02%)	⬆️
...es/handlers/issuance/holder/states/request_sent.rs	73.68% <0.00%> (+3.68%)	⬆️
...handlers/issuance/issuer/states/credential_sent.rs	0.00% <ø> (ø)
...ries/handlers/issuance/issuer/states/offer_sent.rs	50.00% <ø> (ø)
...dlers/issuance/issuer/states/requested_received.rs	68.42% <ø> (+0.92%)	⬆️
libvcx/src/aries/handlers/issuance/messages.rs	33.33% <0.00%> (+2.56%)	⬆️
...ies/handlers/proof_presentation/prover/messages.rs	18.75% <0.00%> (+1.10%)	⬆️
...dlers/proof_presentation/prover/states/finished.rs	54.54% <ø> (+4.54%)	⬆️
...of_presentation/prover/states/presentation_sent.rs	70.58% <ø> (+0.58%)	⬆️
...s/handlers/proof_presentation/verifier/messages.rs	35.71% <ø> (+2.38%)	⬆️
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c872f0e...6cae662. Read the comment docs.

[mirgee]

Thanks @Patrik-Stas, sure I will!