Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated vcx_get_proof, vcx_get_proof_msg doesn't do proof update #247

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Dec 22, 2020

  • Remove deprecated vcx_get_proof (use vcx_get_proof_msg )
  • Change vcx_get_proof_msg behaviour - it should not attempt to perform update on proof state machine
  • Removed skipped nodejs unit tests

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #247 (9a3faf8) into master (f6ada87) will increase coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   57.38%   57.38%           
=======================================
  Files         149      149           
  Lines       20009    19995   -14     
  Branches     4502     4497    -5     
=======================================
- Hits        11482    11474    -8     
+ Misses       5178     5174    -4     
+ Partials     3349     3347    -2     
Flag Coverage Δ
integration 25.97% <0.00%> (+0.02%) ⬆️
unittests 51.66% <38.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/proof.rs 49.33% <38.46%> (-0.03%) ⬇️
...dlers/proof_presentation/verifier/state_machine.rs 76.92% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ada87...9a3faf8. Read the comment docs.

…roof update

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas merged commit c872f0e into master Dec 23, 2020
@Patrik-Stas Patrik-Stas deleted the breaking/get-proof branch December 23, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants