-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace openssl by crates num-bigint, sha2 #317
Conversation
ed28943
to
d51da45
Compare
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 44.45% 44.46% +0.01%
==========================================
Files 417 417
Lines 28975 28964 -11
Branches 6176 6178 +2
==========================================
Hits 12880 12880
+ Misses 12296 12285 -11
Partials 3799 3799
Flags with carried forward coverage won't be shown. Click here to find out more.
|
979fc53
to
5f58a72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 However, there are many newly redundant references to openssl in Android and iOS build scripts, dockerfiles, build.rs
, etc. now. I would prefer to remove these as part of this PR to avoid letting the dead code rot indefinitely.
agree, will do |
cb6f643
to
5f58a72
Compare
@Patrik-Stas just looking at old PRs. is this PR still relevant? libvcx doesn't depend on openssl anymore. but aries-vcx does, should it be migrated? |
Reviving this. We should get back to it at some point in the near future, after the refactors are done. |
5f58a72
to
c518dcf
Compare
aries_vcx/Cargo.toml
Outdated
sha2 = "0.9.5" | ||
num-bigint = "0.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the latest releases?
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
e4192db
to
1638231
Compare
OpenSSL in libvcx is increasing build complexity and has occasionally produced build issues on some platforms.
However there's only 2 use cases for OpenSSL - big numbers and sha256. These problems has been implemented in pure Rust already.
Big numbers and sha hashing is used for encoding credential attributes and is being tested by following tests:
Signed-off-by: Patrik Stas patrik.stas@absa.africa