Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor building problem reports, add logging #561

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@Patrik-Stas Patrik-Stas requested a review from a team as a code owner September 14, 2022 13:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #561 (713c708) into main (7b78b5b) will increase coverage by 0.36%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   61.42%   61.78%   +0.36%     
==========================================
  Files         174      175       +1     
  Lines       18161    18446     +285     
  Branches     3962     4022      +60     
==========================================
+ Hits        11155    11397     +242     
+ Misses       2824     2802      -22     
- Partials     4182     4247      +65     
Flag Coverage Δ
integration-aries-vcx 50.64% <47.82%> (+0.60%) ⬆️
unittests-agency-client 25.85% <ø> (-0.12%) ⬇️
unittests-aries-vcx 55.56% <63.88%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vcx/src/protocols/issuance/issuer/state_machine.rs 71.25% <50.00%> (-0.20%) ⬇️
...vcx/src/protocols/issuance/holder/state_machine.rs 66.62% <54.54%> (-0.14%) ⬇️
...ocols/proof_presentation/verifier/state_machine.rs 71.14% <66.66%> (-0.24%) ⬇️
...otocols/proof_presentation/prover/state_machine.rs 69.50% <71.42%> (-0.23%) ⬇️
aries_vcx/src/protocols/common.rs 76.92% <76.92%> (ø)
agency_client/src/utils/libindy/crypto.rs 40.90% <0.00%> (-4.10%) ⬇️
aries_vcx/src/messages/connection/invite.rs 72.25% <0.00%> (-2.42%) ⬇️
aries_vcx/src/libindy/proofs/prover/prover.rs 44.44% <0.00%> (-1.51%) ⬇️
aries_vcx/src/libindy/wallet.rs 33.33% <0.00%> (-1.05%) ⬇️
aries_vcx/src/libindy/utils/cache.rs 42.55% <0.00%> (-0.93%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@mirgee mirgee merged commit 4039009 into main Sep 20, 2022
@mirgee mirgee deleted the refactoring/problem-report branch September 20, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants