Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make into_did_doc async #569

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Sep 16, 2022

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #569 (9e68ad6) into main (7b78b5b) will decrease coverage by 0.16%.
The diff coverage is 7.04%.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   61.42%   61.26%   -0.17%     
==========================================
  Files         174      174              
  Lines       18161    18158       -3     
  Branches     3962     3985      +23     
==========================================
- Hits        11155    11124      -31     
+ Misses       2824     2817       -7     
- Partials     4182     4217      +35     
Flag Coverage Δ
integration-aries-vcx 49.81% <5.88%> (-0.24%) ⬇️
unittests-agency-client 25.97% <ø> (ø)
unittests-aries-vcx 55.41% <22.72%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/connection/connection.rs 57.73% <0.00%> (-0.91%) ⬇️
aries_vcx/src/handlers/issuance/holder.rs 64.88% <0.00%> (ø)
aries_vcx/src/handlers/issuance/issuer.rs 56.87% <0.00%> (ø)
aries_vcx/src/handlers/out_of_band/receiver.rs 32.65% <0.00%> (ø)
...ries_vcx/src/handlers/proof_presentation/prover.rs 55.70% <0.00%> (ø)
...es_vcx/src/handlers/proof_presentation/verifier.rs 55.62% <0.00%> (ø)
aries_vcx/tests/test_agency.rs 52.01% <0.00%> (ø)
aries_vcx/tests/test_creds_proofs.rs 62.17% <0.00%> (-0.46%) ⬇️
aries_vcx/tests/utils/devsetup_agent.rs 58.14% <0.00%> (-1.13%) ⬇️
aries_vcx/tests/utils/scenarios.rs 70.16% <0.00%> (-1.30%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee force-pushed the refactor/make-into_did_doc-async branch 2 times, most recently from 4aa9f5d to 9e68ad6 Compare September 18, 2022 20:52
@mirgee mirgee marked this pull request as ready for review September 18, 2022 20:52
@mirgee mirgee requested a review from a team as a code owner September 18, 2022 20:52
Patrik-Stas
Patrik-Stas previously approved these changes Sep 19, 2022
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@Patrik-Stas Patrik-Stas merged commit 0539551 into main Sep 19, 2022
@Patrik-Stas Patrik-Stas deleted the refactor/make-into_did_doc-async branch September 19, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants