Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of the release build. #570

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

left-arm
Copy link
Contributor

Disable debug in the release profile.
The build on macOS M1, libvcx.a is about 100 Mb, libvcx.dylib is about 20 Mb.

@left-arm left-arm requested a review from a team as a code owner September 19, 2022 06:32
Disable debug in the release profile.
The build on macOS M1, libvcx.a is about 100 Mb, libvcx.dylib is about 20 Mb.

Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #570 (0481814) into main (b9d817e) will decrease coverage by 8.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   60.93%   52.78%   -8.16%     
==========================================
  Files         175      174       -1     
  Lines       17998    13828    -4170     
  Branches     3966     2506    -1460     
==========================================
- Hits        10967     7299    -3668     
- Misses       2847     4270    +1423     
+ Partials     4184     2259    -1925     
Flag Coverage Δ
integration-aries-vcx ?
unittests-agency-client 25.97% <ø> (ø)
unittests-aries-vcx 55.10% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tocols/proof_presentation/prover/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
aries_vcx/src/handlers/discovery/mod.rs 0.00% <0.00%> (-87.10%) ⬇️
aries_vcx/tests/utils/scenarios.rs 0.00% <0.00%> (-71.10%) ⬇️
aries_vcx/src/utils/provision.rs 0.00% <0.00%> (-65.00%) ⬇️
aries_vcx/tests/utils/devsetup_agent.rs 0.00% <0.00%> (-58.81%) ⬇️
.../src/libindy/credential_def/revocation_registry.rs 0.00% <0.00%> (-51.70%) ⬇️
aries_vcx/src/utils/random.rs 52.94% <0.00%> (-47.06%) ⬇️
aries_vcx/src/libindy/utils/cache.rs 0.00% <0.00%> (-43.48%) ⬇️
...ries_vcx/src/handlers/proof_presentation/prover.rs 14.13% <0.00%> (-40.04%) ⬇️
...tation/prover/states/presentation_proposal_sent.rs 60.00% <0.00%> (-40.00%) ⬇️
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee merged commit 929578f into hyperledger:main Sep 19, 2022
@mirgee mirgee added ci hotfix High priority fixes of unexpected issues labels Sep 23, 2022
@left-arm left-arm deleted the reduce-release-build branch November 28, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants