Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid HTTP request body cloning. #574

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

left-arm
Copy link
Contributor

Consume body passed to post_message(body, url) and update callers.

Fold some long lines while I'm here to improve code readability.

@left-arm left-arm requested a review from a team as a code owner September 19, 2022 09:58
Consume body passed to post_message(body, url) and update callers.

Fold some long lines while I'm here to improve code readability.

Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
@left-arm left-arm force-pushed the avoid-http-request-body-cloning branch from aff6976 to f43bdd8 Compare September 19, 2022 09:59
@codecov-commenter
Copy link

Codecov Report

Merging #574 (f43bdd8) into main (0539551) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   61.82%   61.82%   -0.01%     
==========================================
  Files         174      174              
  Lines       18437    18443       +6     
  Branches     4014     4014              
==========================================
+ Hits        11399    11402       +3     
- Misses       2796     2802       +6     
+ Partials     4242     4239       -3     
Flag Coverage Δ
integration-aries-vcx 50.66% <ø> (ø)
unittests-agency-client 25.85% <0.00%> (-0.15%) ⬇️
unittests-aries-vcx 55.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/api/agent.rs 24.13% <0.00%> (ø)
agency_client/src/api/messaging.rs 0.00% <ø> (ø)
agency_client/src/httpclient.rs 7.01% <0.00%> (-0.83%) ⬇️
agency_client/src/internal/messaging.rs 30.20% <0.00%> (ø)
...vcx/src/protocols/issuance/issuer/state_machine.rs 71.41% <0.00%> (+0.12%) ⬆️
.../src/protocols/connection/inviter/state_machine.rs 70.68% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee merged commit fd9fe8b into main Sep 19, 2022
@mirgee mirgee deleted the avoid-http-request-body-cloning branch September 19, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants