Simplify build of libvcx.so #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #575 +/- ##
==========================================
- Coverage 59.78% 59.10% -0.69%
==========================================
Files 139 198 +59
Lines 15620 19046 +3426
Branches 3627 4356 +729
==========================================
+ Hits 9339 11257 +1918
- Misses 2408 3458 +1050
- Partials 3873 4331 +458
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
left-arm
force-pushed
the
arm/static-libindy
branch
3 times, most recently
from
0f93d66
to
8603a48
Compare
Patrik-Stas
reviewed
Sep 21, 2022
left-arm
force-pushed
the
arm/static-libindy
branch
from
152508b
to
c9baa87
Compare
Closed
mirgee
reviewed
Sep 22, 2022
mirgee
reviewed
Sep 22, 2022
left-arm
force-pushed
the
arm/static-libindy
branch
from
a2ef382
to
627f06c
Compare
left-arm
force-pushed
the
arm/static-libindy
branch
15 times, most recently
from
dc76f20
to
526b127
Compare
left-arm
force-pushed
the
arm/static-libindy
branch
5 times, most recently
from
bdf2363
to
91a7245
Compare
left-arm
force-pushed
the
arm/static-libindy
branch
from
a6070f6
to
6ad0dac
Compare
Patrik-Stas
previously approved these changes
Oct 6, 2022
There was a problem hiding this comment.
The PR is amazing cleanup, great job @left-arm 👍 I appreciate your patience working on this
added 6 commits
October 6, 2022 14:22
Vdr-tools linked as ordinary Rust crate and does not require any additional installation steps. Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
Remove call of libindy::utils::logger::set_default_logger() because it will eventially call EnvLoggerBuilder::new() ... ... .try_init() and try_init() initialize global variable inside create "log". When libindy was linked dynamically, each libvcx.so and libindy.so has a separate instance of that global variable, but with static linking we got double initialization. All calls vcx_set_default_logger() will fail. Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
Signed-off-by: Artem Mironov <artem.mironov@absa.africa>
left-arm
force-pushed
the
arm/static-libindy
branch
from
6ad0dac
to
552e8ec
Compare
mirgee
approved these changes
Oct 6, 2022
Patrik-Stas
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the build of libvcx.
vdr-toolscrates, and updates some dependencies. There are no code changes. Also removed any build scripts (build.rs) sovdr-toolsdoesn't define what and how it will link to. It defines its dependencies inCargo.toml, nothing special here.libvcxlinksvdr-toolsas an ordinary dependency. One don't need to installlibindy.so.cargo buildis enough to buildlibvcx.