Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow obtaining cred rev id from the wallet #614

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 24, 2022

This will eventually allow checking revocation status against ledger and finding the corresponding Holder based on received revocation notification.

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

@mirgee mirgee added the feature label Oct 24, 2022
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/holder-get-cred-rev-id branch from 7e9cce0 to 54a1fc9 Compare October 24, 2022 12:50
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee marked this pull request as ready for review October 24, 2022 13:34
@mirgee mirgee requested a review from a team as a code owner October 24, 2022 13:34
@codecov-commenter
Copy link

Codecov Report

Merging #614 (816bf92) into main (10bc067) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   58.98%   58.91%   -0.07%     
==========================================
  Files         199      200       +1     
  Lines       19218    19273      +55     
  Branches     4369     4385      +16     
==========================================
+ Hits        11336    11355      +19     
- Misses       3551     3564      +13     
- Partials     4331     4354      +23     
Flag Coverage Δ
integration-aries-vcx 47.60% <33.33%> (-0.06%) ⬇️
unittests-agency-client 29.12% <ø> (ø)
unittests-aries-vcx 47.31% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/issuance/holder.rs 64.91% <0.00%> (-0.87%) ⬇️
...vcx/src/protocols/issuance/holder/state_machine.rs 65.27% <0.00%> (-0.65%) ⬇️
...x/src/protocols/issuance/holder/states/finished.rs 30.76% <0.00%> (-1.56%) ⬇️
aries_vcx/src/indy/credentials/mod.rs 38.70% <40.00%> (ø)
aries_vcx/src/indy/credentials/holder/mod.rs 72.54% <66.66%> (-1.27%) ⬇️
agency_client/src/messages/update_com_method.rs 52.63% <0.00%> (ø)
...vcx/src/protocols/issuance/issuer/state_machine.rs 70.65% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Patrik-Stas Patrik-Stas merged commit 4517ef7 into main Oct 25, 2022
@Patrik-Stas Patrik-Stas deleted the feature/holder-get-cred-rev-id branch October 25, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants