Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ios legacy wrapper #683

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Add ios legacy wrapper #683

merged 3 commits into from
Dec 3, 2022

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Dec 2, 2022

  • Adds building and release of ios wrapper ios_legacy, copied from 0.47.0 release (before iOS Wrapper #663) was applied
  • This legacy ios wrapper is added temporarily to make transition smoother and it's expected to be removed in soon future. The main wrapper is wrappers/ios

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner December 2, 2022 11:38
@Patrik-Stas Patrik-Stas changed the title Ios/ios legacy wrapper Add ios legacy wrapper Dec 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #683 (4282c9a) into main (8f0c387) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4282c9a differs from pull request most recent head 4527fd3. Consider uploading reports for the commit 4527fd3 to get more accurate results

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   63.84%   63.84%   -0.01%     
==========================================
  Files         214      214              
  Lines       21000    21000              
  Branches     4702     4701       -1     
==========================================
- Hits        13408    13407       -1     
- Misses       3843     3844       +1     
  Partials     3749     3749              
Flag Coverage Δ
unittests-aries-vcx 63.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vcx/src/handlers/connection/mediated_connection.rs 61.49% <0.00%> (-0.24%) ⬇️
aries_vcx/src/utils/devsetup.rs 72.30% <0.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas merged commit e3ca95c into main Dec 3, 2022
@Patrik-Stas Patrik-Stas deleted the ios/ios-legacy-wrapper branch December 3, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants