Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public agent #715

Merged
merged 9 commits into from
Jan 4, 2023
Merged

Remove public agent #715

merged 9 commits into from
Jan 4, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jan 3, 2023

Removes any and all usage of public agents in the codebase. In Rust integration tests where connection bootstrapping was previously performed via a public agent, an alternative approach was temporarily (i.e. until mediated connection is removed) chosen: the connection request message is sent / received via a channel instead of a DidComm endpoint to avoid overhead associated with managing an open TCP socket per test in Rust. However, vcx-agent-core integration tests do exchange connection requests via DidComm endpoint.

mirgee added 6 commits January 3, 2023 17:36
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee linked an issue Jan 3, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #715 (aa7210a) into main (e671deb) will increase coverage by 0.17%.
The diff coverage is 73.97%.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   64.16%   64.34%   +0.17%     
==========================================
  Files         246      245       -1     
  Lines       22922    22837      -85     
  Branches     5088     5075      -13     
==========================================
- Hits        14709    14694      -15     
+ Misses       4072     4017      -55     
+ Partials     4141     4126      -15     
Flag Coverage Δ
unittests-aries-vcx 64.19% <73.97%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/tests/utils/scenarios.rs 80.46% <62.50%> (-0.92%) ⬇️
...vcx/src/handlers/connection/mediated_connection.rs 63.15% <69.56%> (+0.72%) ⬆️
aries_vcx/tests/test_connection.rs 74.64% <83.33%> (+0.37%) ⬆️
aries_vcx/tests/utils/devsetup_agent.rs 73.01% <100.00%> (+0.35%) ⬆️
aries_vcx/src/handlers/connection/cloud_agent.rs 73.96% <0.00%> (+0.59%) ⬆️
aries_vcx/src/common/ledger/transactions.rs 62.67% <0.00%> (+1.05%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mirgee added 2 commits January 3, 2023 21:17
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though still in draft, preliminary approved from my side, looks great!

Just list of changes to the PR, mainly changes to aries-vcx APIs

@mirgee mirgee marked this pull request as ready for review January 3, 2023 20:34
@mirgee mirgee requested a review from a team as a code owner January 3, 2023 20:34
@Patrik-Stas Patrik-Stas merged commit 8c2e95d into main Jan 4, 2023
@Patrik-Stas Patrik-Stas deleted the refactor/remove-public-agents branch January 4, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PublicAgent and its usage
3 participants