Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonmediated connection handles API #718

Merged
merged 7 commits into from
Jan 5, 2023
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jan 4, 2023

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

mirgee added 4 commits January 4, 2023 12:05
…iated_connection

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee requested a review from a team as a code owner January 4, 2023 15:59
@mirgee mirgee force-pushed the feature/handles-connection branch from 84dc85c to aed9500 Compare January 4, 2023 15:59
Patrik-Stas
Patrik-Stas previously approved these changes Jan 4, 2023
@mirgee mirgee marked this pull request as draft January 4, 2023 16:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #718 (aea2905) into feature/connection-serde (02531ea) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@                     Coverage Diff                      @@
##           feature/connection-serde     #718      +/-   ##
============================================================
- Coverage                     45.33%   45.29%   -0.04%     
============================================================
  Files                           242      242              
  Lines                         17637    17652      +15     
  Branches                       3434     3437       +3     
============================================================
  Hits                           7996     7996              
- Misses                         7291     7306      +15     
  Partials                       2350     2350              
Flag Coverage Δ
unittests-aries-vcx 45.29% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/mod.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mirgee added 3 commits January 4, 2023 20:35
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/handles-connection branch from 4bfa6c3 to aea2905 Compare January 4, 2023 19:36
@mirgee mirgee marked this pull request as ready for review January 5, 2023 11:44
Base automatically changed from feature/connection-serde to main January 5, 2023 11:46
@Patrik-Stas Patrik-Stas merged commit 93de484 into main Jan 5, 2023
@Patrik-Stas Patrik-Stas deleted the feature/handles-connection branch January 5, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants