Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFFI Proof of Concept #737

Merged
merged 12 commits into from
Feb 20, 2023
Merged

UniFFI Proof of Concept #737

merged 12 commits into from
Feb 20, 2023

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Jan 13, 2023

Initializes the proof of concept UniFFI wrapper over the aries-vcx crate.

In scope:

  • initialize project with uniffi dependencies
  • create simple wrapper around connection APIs
  • create uniffi udl for wrapping the connection APIs

out of scope:

  • Build scripts for Android/iOS
  • CI/CD to generate binary & wrappers for consumers
  • Demo applications using the wrappers
  • other protocols
  • advanced error handling
  • fully fleshed out wrapping of message structures

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #737 (5c88d6b) into main (494b14c) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   54.65%   54.41%   -0.24%     
==========================================
  Files         381      381              
  Lines       37155    36766     -389     
  Branches     8080     8089       +9     
==========================================
- Hits        20306    20008     -298     
+ Misses      10895    10803      -92     
- Partials     5954     5955       +1     
Flag Coverage Δ
unittests-aries-vcx 54.31% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvdrtools/indy-wallet/src/storage/mod.rs 21.42% <0.00%> (-17.47%) ⬇️
...c/protocols/connection/invitee/states/completed.rs 16.66% <0.00%> (-11.91%) ⬇️
...c/protocols/connection/inviter/states/completed.rs 20.00% <0.00%> (-10.44%) ⬇️
...c/protocols/connection/invitee/states/responded.rs 37.50% <0.00%> (-9.87%) ⬇️
libvdrtools/src/domain/ledger/did.rs 18.60% <0.00%> (-8.48%) ⬇️
libvdrtools/src/domain/ledger/attrib.rs 24.44% <0.00%> (-7.56%) ⬇️
libvdrtools/src/domain/ledger/schema.rs 37.77% <0.00%> (-7.33%) ⬇️
...c/protocols/connection/inviter/states/requested.rs 50.00% <0.00%> (-6.25%) ⬇️
libvdrtools/src/services/anoncreds/issuer.rs 51.06% <0.00%> (-5.95%) ⬇️
...cols/mediated_connection/invitee/states/initial.rs 63.63% <0.00%> (-5.60%) ⬇️
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@Patrik-Stas
Copy link
Contributor

Sweet! Will you join us for 26th Thursday community call to give us a high level overview?

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Feb 10, 2023

FYI: there's ongoing async PR/discussion in uniffi:
mozilla/uniffi-rs#1409
also
mozilla/uniffi-rs#1306

@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Feb 18, 2023

Hi @gmulhearn I would like to include this in updated readme.md for the edEx course, but would like to point to merged code rather than a PR. How about this plan:

  • let's tweak this by moving code to new root directory (perhaps uniffi_aries_vcx/core or maybeuniffi_vcx/core?) (per Split libvcx, deprecate libvcx::api_c, libvcx-ios, libvcx-java #753 but open to suggestions there)
  • there's currently some merge conflict on the cargo lock file too
  • optionally you can include some very simple readme.md
  • get it merged

The later on we can iterate on this further and

  • add the initial demo with buttons to uniffi_aries_vcx/demos
  • we could then again further iterate and try enable establish connection via simulator

@Patrik-Stas Patrik-Stas mentioned this pull request Feb 18, 2023
a
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
a
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn
Copy link
Contributor Author

@Patrik-Stas PR should now be ready in accordance with your comment above

@gmulhearn gmulhearn changed the title Draft: UniFFI Proof of Concept UniFFI Proof of Concept Feb 19, 2023
@gmulhearn gmulhearn marked this pull request as ready for review February 19, 2023 09:37
@Patrik-Stas Patrik-Stas merged commit cfe9094 into main Feb 20, 2023
@Patrik-Stas Patrik-Stas deleted the gm/uniffi-poc branch February 20, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants