Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose getting and clearing attributes from the ledger #767

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Mar 6, 2023

Expose functions getting and clearing value of the latest attribute transaction for the specified did through the node wrapper API.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the wrappers label Mar 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #767 (d24997f) into main (699bffd) will increase coverage by 0.02%.
The diff coverage is 77.61%.

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   54.56%   54.58%   +0.02%     
==========================================
  Files         380      380              
  Lines       36673    36740      +67     
  Branches     8059     8095      +36     
==========================================
+ Hits        20009    20054      +45     
- Misses      10711    10715       +4     
- Partials     5953     5971      +18     
Flag Coverage Δ
unittests-aries-vcx 54.47% <77.61%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/common/ledger/transactions.rs 62.62% <64.28%> (+0.08%) ⬆️
aries_vcx/tests/test_pool.rs 81.04% <81.13%> (+0.04%) ⬆️
libvdrtools/src/services/pool/request_handler.rs 44.76% <0.00%> (-0.51%) ⬇️
libvdrtools/src/controllers/non_secrets.rs 47.54% <0.00%> (-0.50%) ⬇️
libvdrtools/src/services/pool/mod.rs 52.09% <0.00%> (-0.39%) ⬇️
aries_vcx/src/common/proofs/proof_request.rs 67.72% <0.00%> (-0.21%) ⬇️
libvdrtools/src/services/pool/pool.rs 47.48% <0.00%> (-0.20%) ⬇️
...vcx/src/protocols/issuance/issuer/state_machine.rs 71.08% <0.00%> (-0.12%) ⬇️
libvdrtools/src/services/pool/networker.rs 75.10% <0.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee marked this pull request as ready for review March 7, 2023 11:52
@Patrik-Stas Patrik-Stas merged commit 7a0d3ee into main Mar 7, 2023
@Patrik-Stas Patrik-Stas deleted the wrapper/expose-get-clear-attr branch March 7, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants