Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort error mapping by numeric code #771

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

Patrik-Stas
Copy link
Contributor

Correctness verified by existing tests it_should_map_error_kinds_to_codes and it_should_map_error_codes_to_error_kinds

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

Codecov Report

Merging #771 (9ce5401) into main (4b73b09) will decrease coverage by 24.78%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #771       +/-   ##
===========================================
- Coverage   54.64%   29.86%   -24.78%     
===========================================
  Files         380      378        -2     
  Lines       36762    30526     -6236     
  Branches     8104     6273     -1831     
===========================================
- Hits        20089     9117    -10972     
- Misses      10690    18696     +8006     
+ Partials     5983     2713     -3270     
Flag Coverage Δ
unittests-aries-vcx 29.86% <ø> (-24.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 213 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee merged commit bbcbbf3 into main Mar 15, 2023
@mirgee mirgee deleted the libvcx_core/sort-by-err-code branch March 15, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants