Fix node publishing #784
Merged
Fix node publishing #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
approved these changes
Mar 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 54.66% 53.24% -1.42%
==========================================
Files 381 381
Lines 36858 36864 +6
Branches 8123 8115 -8
==========================================
- Hits 20150 19630 -520
- Misses 10706 11498 +792
+ Partials 6002 5736 -266
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Andy-Waine
pushed a commit
to Andy-Waine/aries-vcx
that referenced
this pull request
Apr 13, 2023
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> Signed-off-by: Andy Waine <88730354+Andy-Waine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changes made in #783,
package.jsonis modified before runningnpm version, which makesnpm versionerror withGit working directory not clean, as it attempts to tag HEAD. This fix disables this default behavior.