Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #796

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Apr 10, 2023

  • Removed unused dependencies across the board
  • vdrtools: Remove unused ffi wallet declarations (in libvdrtools/indy-api-types/src/lib.rs) and unsupported function for wallet plugin registration register_wallet_storage
  • Removed commented tests in vdrtools

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
gmulhearn
gmulhearn previously approved these changes Apr 11, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #796 (a70b5e8) into main (ae0ca7e) will decrease coverage by 24.48%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #796       +/-   ##
===========================================
- Coverage   54.20%   29.73%   -24.48%     
===========================================
  Files         381      379        -2     
  Lines       36850    30598     -6252     
  Branches     8295     6418     -1877     
===========================================
- Hits        19975     9098    -10877     
- Misses      10711    18688     +7977     
+ Partials     6164     2812     -3352     
Flag Coverage Δ
unittests-aries-vcx 29.73% <ø> (-24.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvdrtools/indy-api-types/src/lib.rs 40.00% <ø> (-40.00%) ⬇️
libvdrtools/indy-wallet/src/lib.rs 41.14% <ø> (-15.34%) ⬇️
libvdrtools/src/controllers/wallet.rs 35.06% <ø> (+3.30%) ⬆️
libvdrtools/src/lib.rs 91.07% <ø> (ø)
libvdrtools/src/services/pool/mod.rs 6.63% <ø> (-45.84%) ⬇️
libvdrtools/src/utils/logger.rs 0.00% <ø> (-12.00%) ⬇️

... and 208 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Patrik-Stas Patrik-Stas requested a review from gmulhearn April 11, 2023 12:51
@Patrik-Stas Patrik-Stas merged commit f477a95 into main Apr 12, 2023
@Patrik-Stas Patrik-Stas deleted the dependencies/remove-unused branch April 12, 2023 07:25
Andy-Waine pushed a commit to Andy-Waine/aries-vcx that referenced this pull request Apr 13, 2023
* Remove unnecessary dependencies

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Andy Waine <88730354+Andy-Waine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants