Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support peer:did:3 #886

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Support peer:did:3 #886

merged 1 commit into from
Jun 27, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jun 26, 2023

Adds support for peer did method 3.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #886 (9e0b6af) into main (52a1e43) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9e0b6af differs from pull request most recent head 17581aa. Consider uploading reports for the commit 17581aa to get more accurate results

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   49.90%   49.89%   -0.01%     
==========================================
  Files         432      432              
  Lines       35058    35058              
  Branches     7617     7617              
==========================================
- Hits        17496    17493       -3     
- Misses      12284    12288       +4     
+ Partials     5278     5277       -1     
Flag Coverage Δ
unittests-aries-vcx 49.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
did_parser/src/did.rs 66.66% <ø> (ø)

... and 3 files with indirect coverage changes

@mirgee mirgee force-pushed the feature/did-peer-3 branch 2 times, most recently from 3817886 to aa613aa Compare June 26, 2023 13:45
@mirgee mirgee marked this pull request as ready for review June 26, 2023 14:04
Base automatically changed from feature/did-peer to main June 26, 2023 15:51
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the feature/did-peer-3 branch from aa613aa to 17581aa Compare June 27, 2023 07:28
@Patrik-Stas Patrik-Stas merged commit c1180a7 into main Jun 27, 2023
@Patrik-Stas Patrik-Stas deleted the feature/did-peer-3 branch June 27, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants