Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially #870 - Simple Message Relay for testing/demo purposes #891

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Jul 3, 2023

Impls a dumb relay service for receiving and collecting HTTP message payloads. to be used for testing/demo purposes. Was not too sure about the directory location.. happy to change if anyone has a better spot!

Signed-off-by: gmulhearn <gmulhearn@proton.me>
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #891 (bd7f481) into main (3009224) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   43.36%   43.37%           
=======================================
  Files         438      438           
  Lines       34778    34778           
  Branches     7591     7591           
=======================================
+ Hits        15083    15084    +1     
  Misses      15232    15232           
+ Partials     4463     4462    -1     
Flag Coverage Δ
unittests-aries-vcx 43.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Signed-off-by: gmulhearn <gmulhearn@proton.me>
@Patrik-Stas
Copy link
Contributor

@gmulhearn looks fairly complete, isn't this ready for merge?

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn gmulhearn marked this pull request as ready for review July 19, 2023 08:46
@gmulhearn
Copy link
Contributor Author

@Patrik-Stas yes! just pushed a wrap-up commit! ready for review

Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@Patrik-Stas Patrik-Stas merged commit e1414a8 into main Jul 20, 2023
51 checks passed
@Patrik-Stas Patrik-Stas deleted the gm/870-simple-message-relay branch July 20, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants