Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/remove-mixed-breed #907

Merged
merged 2 commits into from
Jul 24, 2023
Merged

testing/remove-mixed-breed #907

merged 2 commits into from
Jul 24, 2023

Conversation

Patrik-Stas
Copy link
Contributor

One less thing to worry about - since "mixed breed" testing profile was introduced, we have increased coverage with different profile significantly, and also introduced 4x different testing combinations on libvcx_core level.

…per (#895)"

This reverts commit be57e49.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the testing/remove-mixed-breed branch from 1663163 to d0633e7 Compare July 21, 2023 14:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #907 (f38fae4) into revert/napi-wallet-migration (e341f18) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           revert/napi-wallet-migration     #907   +/-   ##
=============================================================
  Coverage                         43.36%   43.37%           
=============================================================
  Files                               438      438           
  Lines                             34777    34777           
  Branches                           7580     7580           
=============================================================
+ Hits                              15082    15083    +1     
+ Misses                            15234    15231    -3     
- Partials                           4461     4463    +2     
Flag Coverage Δ
unittests-aries-vcx 43.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/common/keys.rs 44.64% <ø> (ø)
aries_vcx/src/core/profile/mod.rs 0.00% <ø> (ø)
aries_vcx/src/utils/devsetup.rs 45.51% <ø> (ø)

... and 5 files with indirect coverage changes

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the testing/remove-mixed-breed branch from d0633e7 to f38fae4 Compare July 23, 2023 15:17
@Patrik-Stas Patrik-Stas changed the base branch from main to revert/napi-wallet-migration July 23, 2023 15:18
@Patrik-Stas Patrik-Stas requested a review from bobozaur July 24, 2023 07:25
Base automatically changed from revert/napi-wallet-migration to main July 24, 2023 07:26
@bobozaur bobozaur merged commit 702b209 into main Jul 24, 2023
@bobozaur bobozaur deleted the testing/remove-mixed-breed branch July 24, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants