Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify default libvcx feature flags #908

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Specify default libvcx feature flags #908

merged 1 commit into from
Jul 24, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 23, 2023

  • fix build for libvcx ios/java artifacts (no features flags are selected for ios/java builds, will fail in runtime)
  • fail on compile if no implementation is selected via feature flags

@codecov-commenter
Copy link

Codecov Report

Merging #908 (3b55aa1) into testing/remove-mixed-breed (f38fae4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##           testing/remove-mixed-breed     #908   +/-   ##
===========================================================
  Coverage                       43.37%   43.37%           
===========================================================
  Files                             438      438           
  Lines                           34777    34777           
  Branches                         7580     7580           
===========================================================
+ Hits                            15083    15086    +3     
+ Misses                          15231    15230    -1     
+ Partials                         4463     4461    -2     
Flag Coverage Δ
unittests-aries-vcx 43.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Base automatically changed from testing/remove-mixed-breed to main July 24, 2023 08:29
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@bobozaur bobozaur merged commit c44576e into main Jul 24, 2023
1 of 7 checks passed
@bobozaur bobozaur deleted the fix/libvcx-build branch July 24, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants