Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PublicKey to a separate crate #911

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jul 25, 2023

This allows using PublicKey in the forthcoming did_key crate without importing the entire did_peer crate unnecessarily. The only reason PublicKey resided in the did_peer in the first place was because it was not used anywhere else yet.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

Codecov Report

Merging #911 (c3a2c0b) into main (b49b5d9) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   43.37%   43.31%   -0.07%     
==========================================
  Files         438      439       +1     
  Lines       34777    34823      +46     
  Branches     7580     7589       +9     
==========================================
- Hits        15084    15082       -2     
- Misses      15231    15280      +49     
+ Partials     4462     4461       -1     
Flag Coverage Δ
unittests-aries-vcx 43.31% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
public_key/src/key.rs 0.00% <ø> (ø)

... and 6 files with indirect coverage changes

@mirgee mirgee marked this pull request as ready for review August 10, 2023 12:19
@Patrik-Stas Patrik-Stas merged commit 36c2b98 into main Aug 10, 2023
50 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/move-public-key branch August 10, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants