Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular did:key representation #912

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Modular did:key representation #912

merged 3 commits into from
Aug 10, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jul 26, 2023

Adds a struct representing a did:key, which can then be used, for example, in the services entries of the OOB invitations or did-exchange requests as per the respective RFCs.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

Codecov Report

Merging #912 (7694ada) into refactor/move-public-key (c3a2c0b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           refactor/move-public-key     #912   +/-   ##
=========================================================
  Coverage                     43.31%   43.31%           
=========================================================
  Files                           439      439           
  Lines                         34823    34823           
  Branches                       7589     7587    -2     
=========================================================
+ Hits                          15082    15085    +3     
+ Misses                        15280    15277    -3     
  Partials                       4461     4461           
Flag Coverage Δ
unittests-aries-vcx 43.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@mirgee mirgee marked this pull request as ready for review August 10, 2023 12:20
Patrik-Stas
Patrik-Stas previously approved these changes Aug 10, 2023
Base automatically changed from refactor/move-public-key to main August 10, 2023 13:34
@Patrik-Stas Patrik-Stas dismissed their stale review August 10, 2023 13:34

The base branch was changed.

@Patrik-Stas Patrik-Stas merged commit 9932e47 into main Aug 10, 2023
50 checks passed
@Patrik-Stas Patrik-Stas deleted the feature/did-key branch August 10, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants