Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vdrtool ledger client by indy-vdr client #914

Merged
merged 23 commits into from
Aug 10, 2023
Merged

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 26, 2023

  • Delete ledger/pool/zmq related code from vdrtools
  • Use indy-vdr as ledger client implementation in aries-vcx
  • Enable setting up Transaction Author Agreement for indy-vdr ledger client implementation via libvcx
  • Disabled libvcx android/ios build jobs - not going to let that hinder progress, created issue to track the problem Fix CI build for ios, java libvcx wrappers #916
  • Use indy-vdr fork which enables complete exclusion of selected ledger nodes for which their weight is set to 0.0

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #914 (15372df) into main (e167ed3) will increase coverage by 0.94%.
Report is 3 commits behind head on main.
The diff coverage is 41.54%.

@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   43.33%   44.28%   +0.94%     
==========================================
  Files         438      415      -23     
  Lines       34847    29155    -5692     
  Branches     7609     6218    -1391     
==========================================
- Hits        15101    12911    -2190     
+ Misses      15263    12438    -2825     
+ Partials     4483     3806     -677     
Flag Coverage Δ
unittests-aries-vcx 44.28% <41.54%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/common/keys.rs 44.64% <ø> (ø)
...es_vcx/src/common/proofs/prover/prover_internal.rs 27.27% <ø> (ø)
aries_vcx/src/common/proofs/verifier/verifier.rs 81.64% <0.00%> (-1.38%) ⬇️
aries_vcx/src/common/test_utils.rs 93.54% <ø> (ø)
aries_vcx/src/core/profile/mod.rs 0.00% <ø> (ø)
aries_vcx/src/core/profile/modular_libs_profile.rs 0.00% <0.00%> (ø)
aries_vcx/tests/utils/devsetup_alice.rs 74.37% <ø> (ø)
aries_vcx/tests/utils/devsetup_faber.rs 82.35% <ø> (ø)
aries_vcx/tests/utils/devsetup_util.rs 48.71% <ø> (ø)
aries_vcx_core/src/ledger/base_ledger.rs 0.00% <0.00%> (ø)
... and 18 more

... and 39 files with indirect coverage changes

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the purge/vdrtools-zmq branch 2 times, most recently from 0eb02e8 to 5855757 Compare August 3, 2023 08:04
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the purge/vdrtools-zmq branch 2 times, most recently from a084519 to 828eb2a Compare August 4, 2023 10:17
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Remove vdrtools based ledger client Replace vdrtool ledger client by indy-vdr client Aug 8, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
libvcx/src/api_c/vcx.rs Outdated Show resolved Hide resolved
did_resolver_sov/src/reader/vdr_reader.rs Outdated Show resolved Hide resolved
aries_vcx_core/src/ledger/request_submitter/vdr_ledger.rs Outdated Show resolved Hide resolved
aries_vcx_core/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Co-authored-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
mirgee
mirgee previously approved these changes Aug 10, 2023
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas merged commit 85d8084 into main Aug 10, 2023
38 checks passed
@Patrik-Stas Patrik-Stas deleted the purge/vdrtools-zmq branch August 10, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants