Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild cargo.lock, restore indy-vdr-proxy txn submitter #932

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Aug 10, 2023

It seems due to issue in the indy-vdr-proxy-client cargo.toml file, it was bringing in wrong indy-vdr version and then our dependency tree ended up with 2 versions of indy-vdr.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #932 (34764cf) into main (85d8084) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 34764cf differs from pull request most recent head ede959e. Consider uploading reports for the commit ede959e to get more accurate results

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   44.27%   44.21%   -0.06%     
==========================================
  Files         416      416              
  Lines       29205    29235      +30     
  Branches     6240     6239       -1     
==========================================
- Hits        12930    12927       -3     
- Misses      12466    12499      +33     
  Partials     3809     3809              
Flag Coverage Δ
unittests-aries-vcx 44.21% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

aries_vcx_core/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@mirgee mirgee merged commit 396eb43 into main Aug 11, 2023
32 of 34 checks passed
@mirgee mirgee deleted the fix/indy-vdr-proxy branch August 11, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants