-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove msg-sending IO from Connection protocol #937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
force-pushed
the
connection/ioless
branch
from
August 19, 2023 21:53
530a1a8
to
4a73b39
Compare
Codecov Report
@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 39.35% 39.46% +0.11%
==========================================
Files 417 415 -2
Lines 28986 28906 -80
Branches 6185 6174 -11
==========================================
+ Hits 11407 11408 +1
+ Misses 14236 14155 -81
Partials 3343 3343
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
force-pushed
the
connection/ioless
branch
8 times, most recently
from
August 22, 2023 14:56
a71a5ef
to
5d0a6af
Compare
Patrik-Stas
force-pushed
the
connection/ioless
branch
from
August 29, 2023 21:59
25f1e1e
to
5355c1e
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
…files Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
connection/ioless
branch
from
August 30, 2023 06:23
5355c1e
to
11cbec1
Compare
mirgee
approved these changes
Aug 31, 2023
Patrik-Stas
changed the title
Modify connection inviter to extract msg sending out
Remove msg-sending IO from Connection protocol
Aug 31, 2023
Patrik-Stas
pushed a commit
that referenced
this pull request
Sep 1, 2023
bobozaur
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Remove msg-sending IO from Connection protocol (#937) Signed-off-by: Patrik Stas <patrik.stas@absa.africa> Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Patrik-Stas
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove message sending IO from Connection protocol state machines
Changes
Inviter
Responded
stateInviterConnection<Requested>
:send_response
get_connection_response_msg
Invitee
in state
InviteeConnection<Responded>
send_ack
get_ack
in state
InviteeConnection<Invited>
send_request
prepare_request
in state
InviteeConnection<Requested>
handle_response
fromInviteeConnection<Responded>
toInviteeConnection<Completed>
remove state
Responded
Breaking Changes
Responded
. Existing state machines in such state won't be deserializable anymore.