Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile building in tests, considering vdrtools is default feature #960

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Aug 29, 2023

  • When profile is selected dynamically based on feature flags (in testing), it would previously always select always vdrtools profile, regardless of modular_libs feature being enabled.
  • This bug was probably brought in some of the relatively recent test setup / feature refactoring.
  • Nevertheless the modular libs (which were apparently not being tested in CI since introduction of the bug) are passing fine ✅

Proper solution though, should be removing vdrtools as default feature

  • had a quick shot at it, but it's a bit trickier, as tests require vdrtools wallet regardless of whether we are running with credx/vdrtools anoncreds
  • it's possible to address, but figured it'll be easier just to wait out for vdrtools anoncreds to die out

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas marked this pull request as ready for review August 29, 2023 18:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #960 (68db602) into main (ce61866) will decrease coverage by 5.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   44.46%   39.35%   -5.12%     
==========================================
  Files         417      417              
  Lines       28995    28986       -9     
  Branches     6184     6185       +1     
==========================================
- Hits        12894    11408    -1486     
- Misses      12298    14235    +1937     
+ Partials     3803     3343     -460     
Flag Coverage Δ
unittests-aries-vcx 39.35% <0.00%> (-5.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/common/primitives/mod.rs 83.49% <0.00%> (ø)
aries_vcx/src/utils/devsetup.rs 47.55% <0.00%> (+0.18%) ⬆️

... and 64 files with indirect coverage changes

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming happy CI 👌

@gmulhearn gmulhearn merged commit f8aaadc into main Aug 30, 2023
30 checks passed
@gmulhearn gmulhearn deleted the fix/testing branch August 30, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants