Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniffi remove autogenerated bindings #968

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

swaptr
Copy link
Contributor

@swaptr swaptr commented Sep 6, 2023

Autogenerated uniffi bindings can be untracked by default. Merge after #954.

@swaptr swaptr self-assigned this Sep 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #968 (527e188) into main (41ce02b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files         414      414           
  Lines       28863    28863           
  Branches     6183     6183           
=======================================
+ Hits        11349    11350    +1     
  Misses      14175    14175           
+ Partials     3339     3338    -1     
Flag Coverage Δ
unittests-aries-vcx 39.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@gmulhearn gmulhearn mentioned this pull request Sep 7, 2023
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks. FYI @Patrik-Stas

@gmulhearn gmulhearn merged commit 899789e into hyperledger:main Sep 7, 2023
30 checks passed
bobozaur pushed a commit that referenced this pull request Sep 14, 2023
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Co-authored-by: George Mulhearn <57472912+gmulhearn@users.noreply.github.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants