Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eradicate mediated connection from issuance and presentation integration tests, part 2 #974

Merged
merged 12 commits into from
Sep 12, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Sep 11, 2023

Continuation of #967.

  • Completely removes usage of MediatedConnection and agency_client from any and all integration tests.
  • Removes legacy agency tests.
  • MySQL tests are preserved, where keypair generation is used to test MySQL connection.
  • Redundant integration_tests and tests modules were removed.
  • Alice and Faber were significantly pruned, where the plan is to replace them with a singular test agent impl.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
…deduplicate

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
…ber_trustee

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
Patrik-Stas previously approved these changes Sep 12, 2023
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing again :-) Huge burden droped off once more

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/integration-tests-cntd branch from b2f724d to e115aa3 Compare September 12, 2023 09:41
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #974 (134c147) into main (3b77552) will decrease coverage by 5.39%.
The diff coverage is 78.87%.

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   35.14%   29.76%   -5.39%     
==========================================
  Files         413      411       -2     
  Lines       27471    26070    -1401     
  Branches     5811     5315     -496     
==========================================
- Hits         9656     7759    -1897     
- Misses      14776    16001    +1225     
+ Partials     3039     2310     -729     
Flag Coverage Δ
unittests-aries-vcx 29.76% <78.87%> (-5.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/tests/test_creds_proofs.rs 81.81% <ø> (-0.41%) ⬇️
.../msg_fields/protocols/connection/invitation/mod.rs 60.00% <66.66%> (+10.00%) ⬆️
aries_vcx/src/protocols/connection/generic/mod.rs 9.60% <72.72%> (+9.59%) ⬆️
aries_vcx/tests/test_creds_proofs_revocations.rs 79.80% <75.58%> (+0.02%) ⬆️
aries_vcx/tests/utils/scenarios.rs 78.97% <78.79%> (+1.36%) ⬆️
aries_vcx/tests/utils/test_agent.rs 78.94% <78.94%> (ø)
aries_vcx/tests/test_connection.rs 80.00% <79.62%> (+5.44%) ⬆️
aries_vcx/tests/test_pool.rs 83.49% <81.52%> (-0.33%) ⬇️
aries_vcx/src/handlers/util.rs 16.66% <100.00%> (+3.72%) ⬆️
aries_vcx/tests/test_mysql_wallet.rs 92.30% <100.00%> (+1.39%) ⬆️

... and 106 files with indirect coverage changes

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee requested a review from Patrik-Stas September 12, 2023 12:23
@Patrik-Stas Patrik-Stas merged commit 7558c3d into main Sep 12, 2023
@Patrik-Stas Patrik-Stas deleted the refactor/integration-tests-cntd branch September 12, 2023 12:32
bobozaur pushed a commit that referenced this pull request Sep 14, 2023
…ion tests, part 2 (#974)

Integration test refactoring

* Remove agency+mysql tests, useless modules, group scenarios
* Eliminate MediatedConnection from integration tests
* Refactor connection establishing, remove redundant connection tests, deduplicate
* Remove agency_client from Alice and Faber and prune, remove create_faber_trustee
* Remove create_schema as Faber method
* Remove Faber's endpoint service creation
* Remove schema from Faber, init_issuer_config
* Remove alice, use extracted faber endpoint creation in connection tests
* Rename Faber to TestAgent
* Remove TestTransport

---------

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants