-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eradicate mediated connection from issuance and presentation integration tests, part 2 #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
…deduplicate Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
…ber_trustee Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
reviewed
Sep 12, 2023
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
previously approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing again :-) Huge burden droped off once more
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
mirgee
force-pushed
the
refactor/integration-tests-cntd
branch
from
September 12, 2023 09:41
b2f724d
to
e115aa3
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
==========================================
- Coverage 35.14% 29.76% -5.39%
==========================================
Files 413 411 -2
Lines 27471 26070 -1401
Branches 5811 5315 -496
==========================================
- Hits 9656 7759 -1897
- Misses 14776 16001 +1225
+ Partials 3039 2310 -729
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Patrik-Stas
approved these changes
Sep 12, 2023
bobozaur
pushed a commit
that referenced
this pull request
Sep 14, 2023
…ion tests, part 2 (#974) Integration test refactoring * Remove agency+mysql tests, useless modules, group scenarios * Eliminate MediatedConnection from integration tests * Refactor connection establishing, remove redundant connection tests, deduplicate * Remove agency_client from Alice and Faber and prune, remove create_faber_trustee * Remove create_schema as Faber method * Remove Faber's endpoint service creation * Remove schema from Faber, init_issuer_config * Remove alice, use extracted faber endpoint creation in connection tests * Rename Faber to TestAgent * Remove TestTransport --------- Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #967.
MediatedConnection
andagency_client
from any and all integration tests.integration_tests
andtests
modules were removed.