Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tokio, android_logger deps from agency_client #975

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Remove tokio, android_logger deps from agency_client #975

merged 1 commit into from
Sep 13, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Sep 12, 2023 •
edited
Loading

  • removes tokio dependency at cost of one test (very low value)
  • also removed unused android_logger dependency

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #975 (681ab95) into main (f4c8642) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   29.22%   29.23%           
=======================================
  Files         414      414           
  Lines       26246    26246           
  Branches     5365     5365           
=======================================
+ Hits         7671     7672    +1     
  Misses      16263    16263           
+ Partials     2312     2311    -1
Flag Coverage Δ
unittests-aries-vcx 29.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
agency_client/src/messages/create_key.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@Patrik-Stas @bobozaur
Remove tokio dev-dep from agency_client
681ab95 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@bobozaur bobozaur merged commit 5232d08 into main Sep 13, 2023
32 checks passed
@bobozaur bobozaur deleted the deps/cleanup branch September 13, 2023 11:48
bobozaur pushed a commit that referenced this pull request Sep 14, 2023
@Patrik-Stas @bobozaur
Remove tokio dev-dep from agency_client (#975)
3040bfe 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobozaur bobozaur bobozaur approved these changes

@mirgee mirgee Awaiting requested review from mirgee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Patrik-Stas @codecov-commenter @bobozaur