Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further integration test refactoring #979

Merged
merged 13 commits into from
Sep 15, 2023
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Sep 15, 2023

  • Groups tests based on tested scenarios.
  • Groups helper functions in tests/scenarios based on concern (connection, proof presentation, issuance).
  • Extracts schema / credential data hardcoded across tests into one place.
  • Multiple presentation generation tests (test_agency_pool_proof_should_be_validated, test_agency_pool_generate_self_attested_proof, test_agency_pool_generate_proof_with_predicates) were joined into one (test_agency_pool_generate_proof), adds generated proof verification.
  • Many smaller tweaks and renames.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
… integration tests

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee marked this pull request as ready for review September 15, 2023 10:46
@Patrik-Stas Patrik-Stas merged commit 9b7ce90 into main Sep 15, 2023
32 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/integration-tests branch September 15, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants