Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/test #995

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Refactor/test #995

merged 1 commit into from
Oct 4, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Sep 25, 2023

  • simplify implementation of create_and_write_test_schema
  • consequently get_schema_attrs became dead code, deleted that and associated test
  • removed libvcx test create_revocable_cred_def_and_check_tails_location and assured equivalent assert in existing aries-vcx test test_pool_get_rev_reg
  • rename create_and_write_test_rev_reg to create_and_publish_test_rev_reg

@Patrik-Stas Patrik-Stas force-pushed the refactor/test branch 2 times, most recently from 593be88 to 297e5fc Compare September 25, 2023 12:03
@Patrik-Stas Patrik-Stas force-pushed the deps/trim-tokio branch 2 times, most recently from ee684d5 to d1420fa Compare September 25, 2023 17:41
@Patrik-Stas Patrik-Stas force-pushed the refactor/test branch 3 times, most recently from a5acdcb to b41f9e9 Compare October 2, 2023 14:48
@Patrik-Stas Patrik-Stas changed the base branch from deps/trim-tokio to main October 2, 2023 14:48
@Patrik-Stas Patrik-Stas force-pushed the refactor/test branch 3 times, most recently from 0aa5d1d to 37ccd52 Compare October 3, 2023 12:37
@Patrik-Stas Patrik-Stas requested review from bobozaur and mirgee and removed request for bobozaur October 3, 2023 14:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #995 (1f9101e) into main (77c8d8f) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 80.95%.

❗ Current head 1f9101e differs from pull request most recent head c9d9c13. Consider uploading reports for the commit c9d9c13 to get more accurate results

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   30.38%   30.38%   -0.01%     
==========================================
  Files         422      422              
  Lines       26248    26281      +33     
  Branches     5085     5091       +6     
==========================================
+ Hits         7975     7985      +10     
- Misses      16055    16070      +15     
- Partials     2218     2226       +8     
Flag Coverage Δ
unittests-aries-vcx 30.38% <80.95%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aries_vcx/src/common/anoncreds.rs 82.88% <100.00%> (ø)
aries_vcx/src/common/credentials/mod.rs 81.81% <100.00%> (ø)
aries_vcx/tests/test_proof_presentation.rs 86.36% <100.00%> (ø)
...s_vcx/tests/utils/scenarios/credential_issuance.rs 84.68% <100.00%> (ø)
aries_vcx/src/common/test_utils.rs 94.11% <90.00%> (-0.14%) ⬇️
aries_vcx/tests/test_pool.rs 85.11% <66.66%> (-0.19%) ⬇️
...ies_vcx/src/common/primitives/credential_schema.rs 17.18% <33.33%> (+5.60%) ⬆️

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas merged commit 55f0df0 into main Oct 4, 2023
40 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/test branch October 4, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants