Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Besu updates for Dencun #1537

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Document Besu updates for Dencun #1537

merged 13 commits into from
Mar 14, 2024

Conversation

bgravenorst
Copy link
Contributor

@bgravenorst bgravenorst commented Mar 11, 2024 •
edited
Loading

This includes the following:

  • Add conceptual info regarding transaction blobs
  • Document eth_blobBaseFee
  • Update eth_feeHistory and eth_call

Fixes #1521 #1532

@bgravenorst
initial updates.
6e479f0 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst
Update API methods.
df1d3e4 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst
Typo
d07ba55 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst bgravenorst requested a review from a team as a code owner March 11, 2024 23:57
@vercel Vercel
Copy link

vercel bot commented Mar 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:33pm

@bgravenorst
Add project word.
a8a9dce 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst @macfarla
Apply suggestions from code review
0c1d4f7 
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com>
@bgravenorst
Merge remote-tracking branch 'upstream/main' into DOC-1521
2c08b20
@bgravenorst
Incorporate feedback.
49aa4e2 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst
Incorporate feedback.
217794e 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst
Fix broken link.
86d8ad7 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
@bgravenorst
blogs -> blobs
4c6cf35 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
joaniefromtheblock
joaniefromtheblock approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor suggestion

@bgravenorst
Address peer review feedback.
b0ab343 
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
macfarla
macfarla approved these changes Mar 12, 2024
View reviewed changes
docs/public-networks/concepts/transactions/types.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
Gabriel-Trintinalia
Gabriel-Trintinalia reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor suggestions

@bgravenorst @macfarla @Gabriel-Trintinalia
Apply suggestions from code review
1a441d3 
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com>
@bgravenorst bgravenorst merged commit 53789db into hyperledger:main Mar 14, 2024
8 of 9 checks passed
@bgravenorst bgravenorst deleted the DOC-1521 branch March 14, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia left review comments

@joaniefromtheblock joaniefromtheblock joaniefromtheblock approved these changes

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document eth_blobBaseFee
4 participants
@bgravenorst @macfarla @Gabriel-Trintinalia @joaniefromtheblock