Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to correct example #1721

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Update to correct example #1721

merged 5 commits into from
Oct 22, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Oct 22, 2024

Description

  • Update example to reflect correct syntax

Issue(s) fixed

Fixes #1697

Preview

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 5:20pm

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review October 22, 2024 16:31
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner October 22, 2024 16:31
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion.

Also, I feel like the entire CLI reference needs work, so I raised a related issue: #1722

docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
joaniefromtheblock and others added 2 commits October 22, 2024 13:18
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock merged commit 7af9b62 into main Oct 22, 2024
10 checks passed
@joaniefromtheblock joaniefromtheblock deleted the update-pool-transact branch October 22, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tx-pool-max-prioritized-by-type incorrect type
3 participants