New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIP-2537 using gnark-crypto #168

Merged

garyschulte merged 35 commits into hyperledger:main from garyschulte:feature/gnark-bls12-381

Jun 25, 2024

Contributor

garyschulte commented May 11, 2024 •

edited

Loading

Implement eip-2537 using gnark-crypto.

related to #165
related to #91

implements EIP-2537 using gnark-crypto, including as-spec'd subgroup checks and is-on-curve checks.
implements EIP-196 using gnark-crypto, adds test cases
adds test cases for EIP-196 to matter-labs implementation
shims gnark-crypto implementation to be a drop-in replacement for matter-labs

Motivation

The primary motivation is to get besu onto a supported library for the ECC precompiles since the matter-labs eip-1962 repo appears to be unmaintained. There is additional benefit in that gnark-crypto performs better than matter labs on every precompile benchmark.

Testing on both x86_64 and ARM64 indicate this implementation compares very favorably with the matter-labs eip-1962 implementation for all operations.

Screenshot 2024-06-11 at 1 59 16 PM

Screenshot 2024-06-06 at 4 55 57 PM

Screenshot 2024-06-06 at 4 56 07 PM

Screenshot 2024-06-11 at 1 58 20 PM

Screenshot 2024-06-06 at 4 56 21 PM

Screenshot 2024-06-06 at 4 56 30 PM

Screenshot 2024-06-06 at 4 56 41 PM

Screenshot 2024-06-06 at 4 56 49 PM

Screenshot 2024-06-06 at 4 56 57 PM

Screenshot 2024-06-07 at 8 04 37 AM

Screenshot 2024-06-07 at 8 04 30 AM

Screenshot 2024-06-07 at 8 04 46 AM

garyschulte force-pushed the feature/gnark-bls12-381 branch from 635f81f to 4a62528 Compare

June 6, 2024 20:25

garyschulte marked this pull request as ready for review

June 6, 2024 20:28

garyschulte commented

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

garyschulte commented

View reviewed changes

gnark/gnark-jni/gnark-eip-2537.go Outdated Show resolved Hide resolved

garyschulte commented

View reviewed changes

gnark/gnark-jni/gnark-eip-2537.go Outdated Show resolved Hide resolved

garyschulte commented

View reviewed changes

gnark/gnark-jni/gnark-eip-2537.go Outdated Show resolved Hide resolved

garyschulte commented

View reviewed changes

gnark/gnark-jni/gnark-eip-2537.go Outdated Show resolved Hide resolved

garyschulte commented

View reviewed changes

Contributor Author

garyschulte left a comment

fix a few minor things

gnark/src/main/java/org/hyperledger/besu/nativelib/gnark/LibGnarkEIP2537.java Show resolved Hide resolved

gnark/src/test/java/org/hyperledger/besu/nativelib/gnark/BLS12G1AddPrecompiledContractTest.java Outdated Show resolved Hide resolved

garyschulte changed the title ~~Implement EIP-2537 in gnark~~ Implement EIP-2537 using gnark-crypto

garyschulte requested review from shemnon and pinges

June 20, 2024 21:11

shemnon approved these changes

View reviewed changes

Contributor

shemnon left a comment

If gnark is the library of choice, should we make a plan to remove matterlabs from this repo?

build.gradle Outdated Show resolved Hide resolved

Contributor Author

garyschulte commented Jun 24, 2024

If gnark is the library of choice, should we make a plan to remove matterlabs from this repo?

Once we have a besu release with gnark-crypto, we can remove matter labs and the original altbn128 implementation 👍

garyschulte force-pushed the feature/gnark-bls12-381 branch from f1023b6 to 8b0825d Compare

June 24, 2024 14:54

garyschulte added a commit that referenced this pull request


          re-bump to 4.3.3 upload actions and revert to java17 until #168 merges

35b1df6

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte added a commit that referenced this pull request


          revert to java 17 unti #168 merges

8d46382

Signed-off-by: garyschulte <garyschulte@gmail.com>

ryjones pushed a commit that referenced this pull request


          revert to java 17 unti #168 merges

7524af2

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte added 13 commits

June 25, 2024 08:41


          initial gnark eip-2537 skeleton

8473c93

Signed-off-by: garyschulte <garyschulte@gmail.com>


          working g1Add poc, with test

651d00f

Signed-off-by: garyschulte <garyschulte@gmail.com>


          cleaner version of 2537 G1Add

9fd1a3a

Signed-off-by: garyschulte <garyschulte@gmail.com>


          test timings for G1Add

8ecfeb0

Signed-off-by: garyschulte <garyschulte@gmail.com>


          impl and timings for G1Mul

Signed-off-by: garyschulte <garyschulte@gmail.com>


          PoC implementation for G1Add G1Mul G2Add G2Mul

f110aaf

Signed-off-by: garyschulte <garyschulte@gmail.com>


          add G1MultiExp

b7050b6

Signed-off-by: garyschulte <garyschulte@gmail.com>


          G2MultiExp, FpToG1, Fp2ToG2, start on pairing

8f4d3b4

Signed-off-by: garyschulte <garyschulte@gmail.com>


          pairings, some csv test fixture tweaks

989d53d

Signed-off-by: garyschulte <garyschulte@gmail.com>


          revert timings changes to matter-labs bls12-381

2ebf7db

Signed-off-by: garyschulte <garyschulte@gmail.com>


          test cleanup

a0486a3

Signed-off-by: garyschulte <garyschulte@gmail.com>


          attempt at DRY

38a8c1a

Signed-off-by: garyschulte <garyschulte@gmail.com>


          linux arm64 and amd64 targets

a4ffb7b

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte added 22 commits

June 25, 2024 08:41


          add 2537 lib to build.sh

4125f73

Signed-off-by: garyschulte <garyschulte@gmail.com>


          initial timings with idiomatic jblst

379cc71

Signed-off-by: garyschulte <garyschulte@gmail.com>


          g1multiExpr jblst timings

9ca4b91

Signed-off-by: garyschulte <garyschulte@gmail.com>


          G1/G2 written and tested.

104dff0

Still todo:pairing and fpToG1 fpToG2

Signed-off-by: garyschulte <garyschulte@gmail.com>


          pairing

ddc2f24

Signed-off-by: garyschulte <garyschulte@gmail.com>


          fp_to_g1 and fp2_to_g2 implemented, but mapping function is incorrect

2e8d33e

Signed-off-by: garyschulte <garyschulte@gmail.com>


          built using local build of jblst 0.3.12 with P1.map_to and P2.map_to …

ed9bef0

…exposed

Signed-off-by: garyschulte <garyschulte@gmail.com>


          SKIP_CI

ddc7ea3

clean up blst implementation, remove timings and test loops

Signed-off-by: garyschulte <garyschulte@gmail.com>


          clean up for merge

8a69a56

Signed-off-by: garyschulte <garyschulte@gmail.com>


          add eip-196 to gnark bindings. add shims for drop-in-replacement for …

28e9794

…matter-labs impl in besu

Signed-off-by: garyschulte <garyschulte@gmail.com>


          shim gnark eip-2537 implementation for drop-in replacement for matter…

c2e497c

…-labs

add gnark eip-196 implementation and tests
add tests to matter-labs eip-196 for comparison
TODO: gnark eip-197 pairing currently failing

Signed-off-by: garyschulte <garyschulte@gmail.com>


          fix pairing deserialization

d987074

use gnark native Unmarshal for all eip196
cleanup for PR review

Signed-off-by: garyschulte <garyschulte@gmail.com>


          added additional pairing test vectors to bls12-381 for performance co…

da003be

…mparison with gnark

Signed-off-by: garyschulte <garyschulte@gmail.com>


          additional test cases from eip-196

5a2fa1c

Signed-off-by: garyschulte <garyschulte@gmail.com>


          PR fixup

86469e1

Signed-off-by: garyschulte <garyschulte@gmail.com>


          use error SetBytesCanonical for gnark bls12-381, use error array inst…

…ead of repurposing output array

Signed-off-by: garyschulte <garyschulte@gmail.com>


          use passed in lengths, but defer to max val

2a642e7

Signed-off-by: garyschulte <garyschulte@gmail.com>


          add nonMontogomery marshalling, add test cases found in reference tes…

35eb1bc

…ts, clean up 2537 implementation

Signed-off-by: garyschulte <garyschulte@gmail.com>


          fix g1Add edge case for eip196

03cf505

Signed-off-by: garyschulte <garyschulte@gmail.com>


          fix bounds problem with eip196 ecmul, add test cases covering partial…

c4cb76c

… scalar behavior

Signed-off-by: garyschulte <garyschulte@gmail.com>


          bump to java21 and gradle 8.8, bump version to 0.9.0-SNAPSHOT, use gn…

9f694fe

…ark-crypto PR 510 until gnark-crypto is released

Signed-off-by: garyschulte <garyschulte@gmail.com>


          rebase and bump GHA to java 21

7686ae2

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte force-pushed the feature/gnark-bls12-381 branch from 8b0825d to 7686ae2 Compare

June 25, 2024 15:42

shemnon approved these changes

View reviewed changes

garyschulte merged commit fd81455 into hyperledger:main

11 checks passed

garyschulte deleted the feature/gnark-bls12-381 branch

June 25, 2024 18:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet