Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable arm blake2b #82

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Disable arm blake2b #82

merged 2 commits into from
Sep 21, 2022

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Sep 21, 2022

Benchmarking shows the blake on arm code is slower than the java versions running on arm, so don't build it.

Signed-off-by: Danno Ferrin danno.ferrin@gmail.com

Benchmarking shows the blake on arm code is slower than the java
versions running on arm, so don't build it.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expedient way to omit blake2f on arm.

This might be worth a TODO and an issue to address it in the future so we do not lose track.

@shemnon
Copy link
Contributor Author

shemnon commented Sep 21, 2022

#83

@shemnon shemnon enabled auto-merge (squash) September 21, 2022 04:11
@shemnon shemnon merged commit ac78f09 into hyperledger:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants